Skip to content

Ensure commitment_signed sends splice tlv info on channel reestablish #6519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddustin opened this issue Aug 7, 2023 · 1 comment
Closed

Ensure commitment_signed sends splice tlv info on channel reestablish #6519

ddustin opened this issue Aug 7, 2023 · 1 comment
Assignees
@ddustin

Comments

@ddustin
Copy link
Collaborator

ddustin commented Aug 7, 2023

@rustyrussell notes:

BTW, the reason this ever got unstuck is that we don't send the splice fields at all on reconnection. This is pretty clearly wrong? (See the other place we do towire_commitment_signed)

Also ensure it doesn't send the splice tlv if OP_SPLICE feature is not negotiated.
@ddustin ddustin mentioned this issue Aug 7, 2023
Open
71 tasks
@ddustin ddustin self-assigned this Sep 12, 2023
@ddustin
Copy link
Collaborator Author

ddustin commented Oct 15, 2023

Fixed by #6517

@ddustin ddustin closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddustin ddustin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddustin