You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to ABI differences between different 32-bit targets, the
`size_of_hasher` test wrongly failed on `i686-pc-windows-msvc`.
Although the test case with that name was introduced in GitoxideLabs#1915, the
failure is actually long-standing, in that an analogous faiure
occurred in the old `size_of_sha1` test that preceded it and on
which it is based. That failure only happened when the old
`fast-sha1` feature was enabled, and not with the old `rustsha1`
feature. It was not detected earlier as that target is irregularly
tested, and built with `--no-default-features --features max-pure`
more often than other targets due to difficulties building some
other non-Rust dependencies for it. Since GitoxideLabs#1915, the failure
happens more often, since we now use only one SHA-1 implementation,
`sha1-checked`, so the test always fails on `i686-pc-windows-msvc`.
This changes the test to use `gix_testtools::size_ok`, which makes
a `==` comparison on 64-bit targets but a `<=` comparison on 32-bit
targets where there tends to be more variation in data structures'
sizes. This is similar to the fixes in GitoxideLabs#1687 (77c3c59, fc13fc3).
0 commit comments