You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Test max on s390x (and potentially elsewhere supported)
This modifies the `cross` dockerfile and associated `justfile`
recipes to install dependencies needed for testing beyond max-pure.
This works when installing packages for the cross target is already
working, which is the same scenario where the upgraded `git` (from
the git-core PPA) is installed for the `cross` target. But unlike
`git`, when testing max-pure it is not necessary to install these
libraries. Yet the current approach does install them... but native
builds of them. This is inefficient in the Android test where there
may be no immediately forthcoming way to install appropriate
`cross`-target builds of the libraries.
This extra work should probably be eliminated. But the best way to
do that will depend on whether the two cases of cross targets
(those we can install packages for and those we cannot) remain only
two cases, and whether a single `RUN` script continues to be used,
versus splitting it (or creating multiple `cross` dockerfiles).
This also gives the `cross-test` recipe a `*cargo-test-args`
parameter, and moves `--no-default-features --features max-pure`
out of `cross-test` and into the arguments `cross-test-android`
passes to `cross-test` (causing `*cargo-test-args` to receive it).
The reason for doing this rather than having a parameter that is
put in place of `max-pure`, for which `cross-test-s390x` could
pass `max`, is that it is not obvious that `--no-default-features`
is free of undesired effects when `--workspace` is used: it seems
like it may suppress some features of some tested `gix-*` crate
projects that do not individually recognize `max`. (This differs
from the situation with the journey tests, which test the `ein` and
`gix` executables from by the `gitoxide` crate, which recognizes
`max-pure`.) The intuitive effect of "testing max" is currently to
run the entire test suite with all default features enabled, so
this strives to do that.
This still does not appear sufficient to produce the s390x test
failures mentioned in GitoxideLabs#1687 and discused in GitoxideLabs#1698 comments, even
though this is now running s390x tests with the same full default
features as were used when those failures were observed.
0 commit comments