Skip to content

Commit e94526e

Browse files
committed
Say why we test gix-hashtable instead of gix on armv7
This completes the TODO about investigating what was thought to be an environment error, possibly because it references `LD_PRELOAD`. We can't run `cross test -p gix --target armv7-linux-androideabi` because the armv7 `bash` that runs the test fixture scripts (whose archives are `.gitignore`d) finds the `git` command on the runner, which is an amd64 build, and tries to run it as though it is a dynamically linked armv7 executable. This relates to the use of `cross`; no analogous problem occurs with the i686 builds, which are able to run the amd64 `git` avaialble on the system. There are various ways to try to fix this, but for now we do not have any such fix and this is putting it back to testing with `-p gix-hashtable` on armv7 (while still using `-p gix` on i686), and also replacing the old TODO comment with comments on the newly introduced matrix variable about why `gix` is tested on one target and `gix-hashtable` is tested on another.
1 parent 6771838 commit e94526e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/ci.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,10 @@ jobs:
206206
include:
207207
- target: i686-unknown-linux-musl
208208
cargo: cargo
209+
package-to-test: gix # Without cross, can test gix. Fixture scripts use amd64 git.
209210
- target: armv7-linux-androideabi
210211
cargo: cross
212+
package-to-test: gix-hashtable # With cross, can't test gix. Fixture scripts need armv7 git.
211213
fail-fast: false # FIXME: Remove this after testing.
212214

213215
steps:
@@ -227,9 +229,8 @@ jobs:
227229
- name: check
228230
run: ${{ matrix.cargo }} check -p gix --target ${{ matrix.target }}
229231
- name: Test (unit)
230-
# run high-level unit tests that exercise a lot of code while being pure Rust to ease building test binaries.
231-
# TODO: figure out why `git` doesn't pick up environment configuration so build scripts fail when using `-p gix`.
232-
run: ${{ matrix.cargo }} test -p gix --target ${{ matrix.target }}
232+
# Run high-level unit tests that exercise a lot of code while being pure Rust to ease building test binaries.
233+
run: ${{ matrix.cargo }} test -p ${{ matrix.package-to-test }} --target ${{ matrix.target }}
233234

234235
lint:
235236
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)