Skip to content

Commit e01e78a

Browse files
committed
Clean Up: Update []Param to the new Params type
This commit updates []Param to the new Params type everywhere in the code base. This is a follow up to PR tektoncd#6180 where the type type Params []Param was introduced to allow member functions.
1 parent 9ff6034 commit e01e78a

File tree

67 files changed

+567
-570
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+567
-570
lines changed

docs/pipeline-api.md

+33-36
Original file line numberDiff line numberDiff line change
@@ -713,8 +713,8 @@ PipelineSpec
713713
<td>
714714
<code>params</code><br/>
715715
<em>
716-
<a href="#tekton.dev/v1.Param">
717-
[]Param
716+
<a href="#tekton.dev/v1.Params">
717+
Params
718718
</a>
719719
</em>
720720
</td>
@@ -1071,8 +1071,8 @@ TaskRunDebug
10711071
<td>
10721072
<code>params</code><br/>
10731073
<em>
1074-
<a href="#tekton.dev/v1.Param">
1075-
[]Param
1074+
<a href="#tekton.dev/v1.Params">
1075+
Params
10761076
</a>
10771077
</em>
10781078
</td>
@@ -1591,9 +1591,6 @@ IncludeParamsList
15911591
</table>
15921592
<h3 id="tekton.dev/v1.Param">Param
15931593
</h3>
1594-
<p>
1595-
(<em>Appears on:</em><a href="#tekton.dev/v1.PipelineRunSpec">PipelineRunSpec</a>, <a href="#tekton.dev/v1.ResolverRef">ResolverRef</a>, <a href="#tekton.dev/v1.TaskRunInputs">TaskRunInputs</a>, <a href="#tekton.dev/v1.TaskRunSpec">TaskRunSpec</a>)
1596-
</p>
15971594
<div>
15981595
<p>Param declares an ParamValues to use for the parameter called name.</p>
15991596
</div>
@@ -1811,7 +1808,7 @@ map[string]string
18111808
<h3 id="tekton.dev/v1.Params">Params
18121809
(<code>[]github.com/tektoncd/pipeline/pkg/apis/pipeline/v1.Param</code> alias)</h3>
18131810
<p>
1814-
(<em>Appears on:</em><a href="#tekton.dev/v1.IncludeParams">IncludeParams</a>, <a href="#tekton.dev/v1.Matrix">Matrix</a>, <a href="#tekton.dev/v1.PipelineTask">PipelineTask</a>)
1811+
(<em>Appears on:</em><a href="#tekton.dev/v1.IncludeParams">IncludeParams</a>, <a href="#tekton.dev/v1.Matrix">Matrix</a>, <a href="#tekton.dev/v1.PipelineRunSpec">PipelineRunSpec</a>, <a href="#tekton.dev/v1.PipelineTask">PipelineTask</a>, <a href="#tekton.dev/v1.ResolverRef">ResolverRef</a>, <a href="#tekton.dev/v1.TaskRunInputs">TaskRunInputs</a>, <a href="#tekton.dev/v1.TaskRunSpec">TaskRunSpec</a>)
18151812
</p>
18161813
<div>
18171814
<p>Params is a list of Param</p>
@@ -2136,8 +2133,8 @@ PipelineSpec
21362133
<td>
21372134
<code>params</code><br/>
21382135
<em>
2139-
<a href="#tekton.dev/v1.Param">
2140-
[]Param
2136+
<a href="#tekton.dev/v1.Params">
2137+
Params
21412138
</a>
21422139
</em>
21432140
</td>
@@ -3157,8 +3154,8 @@ resolution of the referenced Tekton resource, such as &ldquo;git&rdquo;.</p>
31573154
<td>
31583155
<code>params</code><br/>
31593156
<em>
3160-
<a href="#tekton.dev/v1.Param">
3161-
[]Param
3157+
<a href="#tekton.dev/v1.Params">
3158+
Params
31623159
</a>
31633160
</em>
31643161
</td>
@@ -4634,8 +4631,8 @@ string
46344631
<td>
46354632
<code>params</code><br/>
46364633
<em>
4637-
<a href="#tekton.dev/v1.Param">
4638-
[]Param
4634+
<a href="#tekton.dev/v1.Params">
4635+
Params
46394636
</a>
46404637
</em>
46414638
</td>
@@ -4820,8 +4817,8 @@ TaskRunDebug
48204817
<td>
48214818
<code>params</code><br/>
48224819
<em>
4823-
<a href="#tekton.dev/v1.Param">
4824-
[]Param
4820+
<a href="#tekton.dev/v1.Params">
4821+
Params
48254822
</a>
48264823
</em>
48274824
</td>
@@ -5945,8 +5942,8 @@ EmbeddedRunSpec
59455942
<td>
59465943
<code>params</code><br/>
59475944
<em>
5948-
<a href="#tekton.dev/v1beta1.Param">
5949-
[]Param
5945+
<a href="#tekton.dev/v1beta1.Params">
5946+
Params
59505947
</a>
59515948
</em>
59525949
</td>
@@ -6470,8 +6467,8 @@ EmbeddedRunSpec
64706467
<td>
64716468
<code>params</code><br/>
64726469
<em>
6473-
<a href="#tekton.dev/v1beta1.Param">
6474-
[]Param
6470+
<a href="#tekton.dev/v1beta1.Params">
6471+
Params
64756472
</a>
64766473
</em>
64776474
</td>
@@ -7120,8 +7117,8 @@ EmbeddedCustomRunSpec
71207117
<td>
71217118
<code>params</code><br/>
71227119
<em>
7123-
<a href="#tekton.dev/v1beta1.Param">
7124-
[]Param
7120+
<a href="#tekton.dev/v1beta1.Params">
7121+
Params
71257122
</a>
71267123
</em>
71277124
</td>
@@ -7470,8 +7467,8 @@ PipelineSpec
74707467
<td>
74717468
<code>params</code><br/>
74727469
<em>
7473-
<a href="#tekton.dev/v1beta1.Param">
7474-
[]Param
7470+
<a href="#tekton.dev/v1beta1.Params">
7471+
Params
74757472
</a>
74767473
</em>
74777474
</td>
@@ -7855,8 +7852,8 @@ TaskRunDebug
78557852
<td>
78567853
<code>params</code><br/>
78577854
<em>
7858-
<a href="#tekton.dev/v1beta1.Param">
7859-
[]Param
7855+
<a href="#tekton.dev/v1beta1.Params">
7856+
Params
78607857
</a>
78617858
</em>
78627859
</td>
@@ -8343,8 +8340,8 @@ EmbeddedCustomRunSpec
83438340
<td>
83448341
<code>params</code><br/>
83458342
<em>
8346-
<a href="#tekton.dev/v1beta1.Param">
8347-
[]Param
8343+
<a href="#tekton.dev/v1beta1.Params">
8344+
Params
83488345
</a>
83498346
</em>
83508347
</td>
@@ -8708,7 +8705,7 @@ IncludeParamsList
87088705
<h3 id="tekton.dev/v1beta1.Param">Param
87098706
</h3>
87108707
<p>
8711-
(<em>Appears on:</em><a href="#tekton.dev/v1alpha1.RunSpec">RunSpec</a>, <a href="#tekton.dev/v1beta1.CustomRunSpec">CustomRunSpec</a>, <a href="#tekton.dev/v1beta1.PipelineRunSpec">PipelineRunSpec</a>, <a href="#tekton.dev/v1beta1.ResolverRef">ResolverRef</a>, <a href="#tekton.dev/v1beta1.TaskRunSpec">TaskRunSpec</a>, <a href="#resolution.tekton.dev/v1beta1.ResolutionRequestSpec">ResolutionRequestSpec</a>)
8708+
(<em>Appears on:</em><a href="#resolution.tekton.dev/v1beta1.ResolutionRequestSpec">ResolutionRequestSpec</a>)
87128709
</p>
87138710
<div>
87148711
<p>Param declares an ParamValues to use for the parameter called name.</p>
@@ -8912,7 +8909,7 @@ map[string]string
89128909
<h3 id="tekton.dev/v1beta1.Params">Params
89138910
(<code>[]github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1.Param</code> alias)</h3>
89148911
<p>
8915-
(<em>Appears on:</em><a href="#tekton.dev/v1beta1.IncludeParams">IncludeParams</a>, <a href="#tekton.dev/v1beta1.Matrix">Matrix</a>, <a href="#tekton.dev/v1beta1.PipelineTask">PipelineTask</a>)
8912+
(<em>Appears on:</em><a href="#tekton.dev/v1alpha1.RunSpec">RunSpec</a>, <a href="#tekton.dev/v1beta1.CustomRunSpec">CustomRunSpec</a>, <a href="#tekton.dev/v1beta1.IncludeParams">IncludeParams</a>, <a href="#tekton.dev/v1beta1.Matrix">Matrix</a>, <a href="#tekton.dev/v1beta1.PipelineRunSpec">PipelineRunSpec</a>, <a href="#tekton.dev/v1beta1.PipelineTask">PipelineTask</a>, <a href="#tekton.dev/v1beta1.ResolverRef">ResolverRef</a>, <a href="#tekton.dev/v1beta1.TaskRunSpec">TaskRunSpec</a>)
89168913
</p>
89178914
<div>
89188915
<p>Params is a list of Param</p>
@@ -9277,8 +9274,8 @@ PipelineSpec
92779274
<td>
92789275
<code>params</code><br/>
92799276
<em>
9280-
<a href="#tekton.dev/v1beta1.Param">
9281-
[]Param
9277+
<a href="#tekton.dev/v1beta1.Params">
9278+
Params
92829279
</a>
92839280
</em>
92849281
</td>
@@ -10319,8 +10316,8 @@ resolution of the referenced Tekton resource, such as &ldquo;git&rdquo;.</p>
1031910316
<td>
1032010317
<code>params</code><br/>
1032110318
<em>
10322-
<a href="#tekton.dev/v1beta1.Param">
10323-
[]Param
10319+
<a href="#tekton.dev/v1beta1.Params">
10320+
Params
1032410321
</a>
1032510322
</em>
1032610323
</td>
@@ -12239,8 +12236,8 @@ TaskRunDebug
1223912236
<td>
1224012237
<code>params</code><br/>
1224112238
<em>
12242-
<a href="#tekton.dev/v1beta1.Param">
12243-
[]Param
12239+
<a href="#tekton.dev/v1beta1.Params">
12240+
Params
1224412241
</a>
1224512242
</em>
1224612243
</td>

pkg/apis/pipeline/v1/matrix_types_test.go

+22-22
Original file line numberDiff line numberDiff line change
@@ -119,19 +119,19 @@ func TestMatrix_FanOut(t *testing.T) {
119119
matrix: Matrix{
120120
Include: IncludeParamsList{{
121121
Name: "build-1",
122-
Params: []Param{{
122+
Params: Params{{
123123
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-1"},
124124
}, {
125125
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile1"}}},
126126
}, {
127127
Name: "build-2",
128-
Params: []Param{{
128+
Params: Params{{
129129
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-2"},
130130
}, {
131131
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile2"}}},
132132
}, {
133133
Name: "build-3",
134-
Params: []Param{{
134+
Params: Params{{
135135
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-3"},
136136
}, {
137137
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile3"}}},
@@ -321,7 +321,7 @@ func TestMatrix_FanOut(t *testing.T) {
321321
},
322322
Include: IncludeParamsList{{
323323
Name: "s390x-no-race",
324-
Params: []Param{{
324+
Params: Params{{
325325
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "linux/s390x"},
326326
}, {
327327
Name: "flags", Value: ParamValue{Type: ParamTypeString, StringVal: "-cover -v"}}},
@@ -474,23 +474,23 @@ func TestMatrix_FanOut(t *testing.T) {
474474
},
475475
Include: IncludeParamsList{{
476476
Name: "common-package",
477-
Params: []Param{{
477+
Params: Params{{
478478
Name: "package", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/common/package/"}}},
479479
}, {
480480
Name: "s390x-no-race",
481-
Params: []Param{{
481+
Params: Params{{
482482
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "linux/s390x"},
483483
}, {
484484
Name: "flags", Value: ParamValue{Type: ParamTypeString, StringVal: "-cover -v"}}},
485485
}, {
486486
Name: "go117-context",
487-
Params: []Param{{
487+
Params: Params{{
488488
Name: "version", Value: ParamValue{Type: ParamTypeString, StringVal: "go1.17"},
489489
}, {
490490
Name: "context", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/go117/context"}}},
491491
}, {
492492
Name: "non-existent-arch",
493-
Params: []Param{{
493+
Params: Params{{
494494
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "I-do-not-exist"}},
495495
},
496496
}},
@@ -610,15 +610,15 @@ func TestMatrix_HasParams(t *testing.T) {
610610
{
611611
name: "matrixed with params",
612612
matrix: &Matrix{
613-
Params: []Param{{Name: "platform", Value: ParamValue{ArrayVal: []string{"linux", "windows"}}}},
613+
Params: Params{{Name: "platform", Value: ParamValue{ArrayVal: []string{"linux", "windows"}}}},
614614
},
615615
want: true,
616616
}, {
617617
name: "matrixed with include",
618618
matrix: &Matrix{
619619
Include: IncludeParamsList{{
620620
Name: "build-1",
621-
Params: []Param{{
621+
Params: Params{{
622622
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-1"},
623623
}, {
624624
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile1"}}},
@@ -834,21 +834,21 @@ func TestPipelineTask_CountCombinations(t *testing.T) {
834834
matrix: &Matrix{
835835
Include: IncludeParamsList{{
836836
Name: "build-1",
837-
Params: []Param{{
837+
Params: Params{{
838838
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-1"},
839839
}, {
840840
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile1"},
841841
}},
842842
}, {
843843
Name: "build-2",
844-
Params: []Param{{
844+
Params: Params{{
845845
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-2"},
846846
}, {
847847
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile2"},
848848
}},
849849
}, {
850850
Name: "build-3",
851-
Params: []Param{{
851+
Params: Params{{
852852
Name: "IMAGE", Value: ParamValue{Type: ParamTypeString, StringVal: "image-3"},
853853
}, {
854854
Name: "DOCKERFILE", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/Dockerfile3"},
@@ -859,24 +859,24 @@ func TestPipelineTask_CountCombinations(t *testing.T) {
859859
}, {
860860
name: "params and include in matrix with overriding combinations params",
861861
matrix: &Matrix{
862-
Params: []Param{{
862+
Params: Params{{
863863
Name: "GOARCH", Value: ParamValue{ArrayVal: []string{"linux/amd64", "linux/ppc64le", "linux/s390x"}},
864864
}, {
865865
Name: "version", Value: ParamValue{ArrayVal: []string{"go1.17", "go1.18.1"}}},
866866
},
867867
Include: IncludeParamsList{{
868868
Name: "common-package",
869-
Params: []Param{{
869+
Params: Params{{
870870
Name: "package", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/common/package/"}}},
871871
}, {
872872
Name: "s390x-no-race",
873-
Params: []Param{{
873+
Params: Params{{
874874
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "linux/s390x"},
875875
}, {
876876
Name: "flags", Value: ParamValue{Type: ParamTypeString, StringVal: "-cover -v"}}},
877877
}, {
878878
Name: "go117-context",
879-
Params: []Param{{
879+
Params: Params{{
880880
Name: "version", Value: ParamValue{Type: ParamTypeString, StringVal: "go1.17"},
881881
}, {
882882
Name: "context", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/go117/context"}}},
@@ -886,30 +886,30 @@ func TestPipelineTask_CountCombinations(t *testing.T) {
886886
}, {
887887
name: "params and include in matrix with overriding combinations params and one new combination",
888888
matrix: &Matrix{
889-
Params: []Param{{
889+
Params: Params{{
890890
Name: "GOARCH", Value: ParamValue{ArrayVal: []string{"linux/amd64", "linux/ppc64le", "linux/s390x"}},
891891
}, {
892892
Name: "version", Value: ParamValue{ArrayVal: []string{"go1.17", "go1.18.1"}}},
893893
},
894894
Include: IncludeParamsList{{
895895
Name: "common-package",
896-
Params: []Param{{
896+
Params: Params{{
897897
Name: "package", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/common/package/"}}},
898898
}, {
899899
Name: "s390x-no-race",
900-
Params: []Param{{
900+
Params: Params{{
901901
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "linux/s390x"},
902902
}, {
903903
Name: "flags", Value: ParamValue{Type: ParamTypeString, StringVal: "-cover -v"}}},
904904
}, {
905905
Name: "go117-context",
906-
Params: []Param{{
906+
Params: Params{{
907907
Name: "version", Value: ParamValue{Type: ParamTypeString, StringVal: "go1.17"},
908908
}, {
909909
Name: "context", Value: ParamValue{Type: ParamTypeString, StringVal: "path/to/go117/context"}}},
910910
}, {
911911
Name: "non-existent-arch",
912-
Params: []Param{{
912+
Params: Params{{
913913
Name: "GOARCH", Value: ParamValue{Type: ParamTypeString, StringVal: "I-do-not-exist"}},
914914
}},
915915
}},

0 commit comments

Comments
 (0)