Skip to content

Node 20 support #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdboom opened this issue Jan 25, 2024 · 3 comments · Fixed by #614
Closed

Node 20 support #613

mdboom opened this issue Jan 25, 2024 · 3 comments · Fixed by #614
Assignees
@EndBug
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: fix Updates to existing functionalities

Comments

@mdboom
Copy link

mdboom commented Jan 25, 2024

Thanks for add-and-commit! It's been a really important part of CPython's continuous benchmarking system.

I am getting the following warnings from my Github actions:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: EndBug/add-and-commit@v9. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Are there plans to release a new version supporting Node 20 that would address this warning?
@mdboom mdboom added the status: pending More info is needed before deciding what to do label Jan 25, 2024
@EndBug EndBug added good first issue Good for newcomers status: pinned Should not be labeled as stale type: fix Updates to existing functionalities and removed status: pending More info is needed before deciding what to do labels Jan 25, 2024
@EndBug EndBug self-assigned this Jan 25, 2024
@EndBug
Copy link
Owner

EndBug commented Jan 25, 2024

Good catch! I'll do it ASAP ;)

@EndBug EndBug mentioned this issue Jan 25, 2024
Merged
@EndBug
Copy link
Owner

EndBug commented Jan 25, 2024

@all-contributors please add @mdboom for their maintenance contribution

@allcontributors allcontributors bot mentioned this issue Jan 25, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @mdboom! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EndBug EndBug

Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: fix Updates to existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: bump node to v20 EndBug/add-and-commit
2 participants
@mdboom @EndBug