some small fixes (#508)

Co-authored-by: Soren Roth <[email protected]>

Author: sorenoid

toolkit/popup/src/main/java/com/arcgismaps/toolkit/popup/internal/element/media/MediaElementState.kt

@@ -77,7 +77,7 @@ internal class MediaElementState(
                         ""
                     },
                     MediaImageProvider(
-                        fileName = "media-${Objects.hash(mediaPopupElement.title, media.title, media.caption)}",
+                        fileName = "media-${Objects.hash(mediaPopupElement.title, media.title, media.caption)}.png",
                         folderName = mediaFolder
                     ) {
                         media.generateChart(chartParams).getOrThrow().image.bitmap
@@ -173,7 +173,7 @@ internal fun rememberMediaElementState(
     val mediaFolder = "${LocalContext.current.cacheDir.canonicalPath}/popup_media"
     val context = LocalContext.current
     return rememberSaveable(
-        inputs = arrayOf(popup, element),
+        inputs = arrayOf(popup, element.toJson()),
         saver = MediaElementState.Saver(element, scope, mediaFolder, chartParams, context)
     ) {
         MediaElementState(

toolkit/popup/src/main/java/com/arcgismaps/toolkit/popup/internal/util/MediaImageProvider.kt

@@ -40,11 +40,9 @@ internal class MediaImageProvider(
         val directory = File(folderName)
         directory.mkdirs()
         val file = File(directory, fileName)
-        if (!file.exists()) {
-            file.createNewFile()
-            BufferedOutputStream(FileOutputStream(file)).use { bos ->
-                bitmap.compress(Bitmap.CompressFormat.PNG, 100, bos)
-            }
+        file.createNewFile()
+        BufferedOutputStream(FileOutputStream(file)).use { bos ->
+            bitmap.compress(Bitmap.CompressFormat.PNG, 100, bos)
         }
         file.canonicalPath
     }