Add SideEffect to Callout (#519)

Author: shubham7109

toolkit/geoview-compose/src/main/java/com/arcgismaps/toolkit/geoviewcompose/GeoViewScope.kt

@@ -31,6 +31,7 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.layout.sizeIn
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.SideEffect
 import androidx.compose.runtime.State
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
@@ -124,15 +125,16 @@ public sealed class GeoViewScope protected constructor(private val geoView: GeoV
         shapes: CalloutShapes = CalloutDefaults.shapes(),
         content: @Composable BoxScope.() -> Unit
     ) {
-        // Enables the recomposition of the first Callout in the content lambda that is displayed
-        // on the MapView/SceneView
-        var allowCalloutRecomposition by remember { mutableStateOf(false) }
-
-        if (this.isCalloutBeingDisplayed.compareAndSet(false, true)
-            || allowCalloutRecomposition
-        ) {
-            allowCalloutRecomposition = true
+        if (this.isCalloutBeingDisplayed.compareAndSet(false, true)) {
             this.CalloutInternal(location, modifier, offset, rotateOffsetWithGeoView, colorScheme, shapes, content)
+
+            SideEffect {
+                // The SideEffect is executed after every successful (re)composition. This means that it runs at the
+                // end of the GeoView's content lambda from which this Callout function was called. Resetting at this point
+                // allows us to run the callout code at subsequent recomposition but also to prevent multiple callouts from
+                // being rendered within a single (re)composition pass.
+                reset()
+            }
         }
     }
 
@@ -165,15 +167,16 @@ public sealed class GeoViewScope protected constructor(private val geoView: GeoV
         shapes: CalloutShapes = CalloutDefaults.shapes(),
         content: @Composable BoxScope.() -> Unit
     ) {
-        // Enables the recomposition of the first Callout in the content lambda that is displayed
-        // on the MapView/SceneView
-        var allowCalloutRecomposition by remember { mutableStateOf(false) }
-
-        if (this.isCalloutBeingDisplayed.compareAndSet(false, true)
-            || allowCalloutRecomposition
-        ) {
-            allowCalloutRecomposition = true
+        if (this.isCalloutBeingDisplayed.compareAndSet(false, true)) {
             this.CalloutInternal(geoElement, modifier, tapLocation, colorScheme, shapes, content)
+
+            SideEffect {
+                // The SideEffect is executed after every successful (re)composition. This means that it runs at the
+                // end of the GeoView's content lambda from which this Callout function was called. Resetting at this point
+                // allows us to run the callout code at subsequent recomposition but also to prevent multiple callouts from
+                // being rendered within a single (re)composition pass.
+                reset()
+            }
         }
     }
 
@@ -189,7 +192,7 @@ public sealed class GeoViewScope protected constructor(private val geoView: GeoV
      *
      * @since 200.5.0
      */
-    internal fun reset() {
+    private fun reset() {
         isCalloutBeingDisplayed.set(false)
     }
 

toolkit/geoview-compose/src/main/java/com/arcgismaps/toolkit/geoviewcompose/MapView.kt

@@ -206,7 +206,6 @@ public fun MapView(
 
         if (isMapViewReady.value) {
             content?.let {
-                mapViewScope.reset()
                 mapViewScope.it()
             }
         }

toolkit/geoview-compose/src/main/java/com/arcgismaps/toolkit/geoviewcompose/SceneView.kt

@@ -211,7 +211,6 @@ public fun SceneView(
 
         if (isSceneViewReady.value) {
             content?.let {
-                sceneViewScope.reset()
                 sceneViewScope.it()
             }
         }