Forms : Read only fields re-design (#346)

Author: kaushikrw

toolkit/featureforms/README.md

@@ -101,7 +101,7 @@ FeatureForm(
 
 #### Text Fields
 - Outline color - `MaterialTheme.colorScheme.outline`
-- Label TextStyle - `MaterialTheme.typography.bodyMedium`
+- Label TextStyle - `MaterialTheme.typography.bodySmall`
 - Input TextStyle - `MaterialTheme.typography.bodyLarge`
 - SupportingText TextStyle - `MaterialTheme.typography.bodySmall`
 - Error color - `MaterialTheme.colorScheme.error`
@@ -121,6 +121,8 @@ FeatureForm(
 - Description TextStyle - `MaterialTheme.typography.bodySmall`
 
 #### Read-Only Fields
-Alpha values for read only fields cannot be customized at this time.
+- Label TextStyle - `MaterialTheme.typography.bodyMedium`
+- Input TextStyle - `MaterialTheme.typography.bodyLarge`
+- SupportingText TextStyle - `MaterialTheme.typography.bodySmall`
 
 More information on the material 3 specs [here](https://m3.material.io/components/text-fields/specs#e4964192-72ad-414f-85b4-4b4357abb83c)

toolkit/featureforms/src/androidTest/java/com/arcgismaps/toolkit/featureforms/FormTextFieldTests.kt

@@ -115,8 +115,7 @@ class FormTextFieldTests {
         val label = composeTestRule.onNodeWithContentDescription(labelSemanticLabel)
         label.assertIsDisplayed()
 
-        val supportingText = composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true)
-        supportingText.assertExists()
+        composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true).assertDoesNotExist()
     }
 
     /**
@@ -134,9 +133,7 @@ class FormTextFieldTests {
         val label = composeTestRule.onNodeWithContentDescription(labelSemanticLabel)
         label.assertIsDisplayed()
 
-        val supportingText = composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true)
-        supportingText.assertExists()
-        assertEquals(field.description, supportingText.getTextString())
+        composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true).assertDoesNotExist()
     }
 
     /**
@@ -155,9 +152,7 @@ class FormTextFieldTests {
         val label = composeTestRule.onNodeWithContentDescription(labelSemanticLabel)
         label.assertIsDisplayed()
 
-        val supportingText = composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true)
-        supportingText.assertExists()
-        assertEquals(field.description, supportingText.getTextString())
+        composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true).assertDoesNotExist()
 
         val charCountNode =
             composeTestRule.onNode(hasContentDescription(charCountSemanticLabel), useUnmergedTree = true)
@@ -185,9 +180,7 @@ class FormTextFieldTests {
         val label = composeTestRule.onNodeWithContentDescription(labelSemanticLabel)
         label.assertIsDisplayed()
 
-        val supportingText = composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true)
-        supportingText.assertExists()
-        assertEquals(field.description, supportingText.getTextString())
+        composeTestRule.onNode(hasContentDescription(supportingTextSemanticLabel), useUnmergedTree = true).assertDoesNotExist()
 
         outlinedTextField.performImeAction()
         outlinedTextField.assertIsNotFocused()

toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/FeatureForm.kt

@@ -173,6 +173,7 @@ private fun FeatureFormBody(
                             // other form elements are not created
                         }
                     }
+                    Divider()
                 }
             }
         }