Forms: DateTimeFieldState refactor (#133)

* init refactor

* textareainput show done button even if field is empty

* introduced classes to wrap common parameters

* Update FormElements.kt

* working remembersaveable

* added remembersaveable outside lazycolumn

* added id for formfieldelement

* optimized imports

* undo changes

* optimized more imports

* updated field element to not remember datetimefieldstate

* migrated DateTimeFieldState to use BaseFieldState

* added saver to DateTimeFieldState

* update doc

Author: kaushikrw

toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/FeatureForm.kt

@@ -30,13 +30,15 @@ import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.arcgismaps.mapping.featureforms.ComboBoxFormInput
+import com.arcgismaps.mapping.featureforms.DateTimePickerFormInput
 import com.arcgismaps.mapping.featureforms.FeatureForm
 import com.arcgismaps.mapping.featureforms.FieldFormElement
 import com.arcgismaps.mapping.featureforms.TextAreaFormInput
 import com.arcgismaps.mapping.featureforms.TextBoxFormInput
 import com.arcgismaps.toolkit.featureforms.components.FieldElement
 import com.arcgismaps.toolkit.featureforms.components.base.BaseFieldState
 import com.arcgismaps.toolkit.featureforms.components.combo.rememberComboBoxFieldState
+import com.arcgismaps.toolkit.featureforms.components.datetime.rememberDateTimeFieldState
 import com.arcgismaps.toolkit.featureforms.components.text.rememberFormTextFieldState
 import kotlinx.coroutines.CoroutineScope
 import java.util.Objects
@@ -126,11 +128,12 @@ internal fun FeatureFormContent(
             items(form.elements) { formElement ->
                 if (formElement is FieldFormElement) {
                     val state = states[formElement.id]
-                    FieldElement(
-                        field = formElement,
-                        form = form,
-                        state = state
-                    )
+                    if (state != null) {
+                        FieldElement(
+                            field = formElement,
+                            state = state
+                        )
+                    }
                 }
             }
         }
@@ -170,6 +173,18 @@ private fun rememberFieldStates(
                     )
                 }
 
+                is DateTimePickerFormInput -> {
+                    val input = fieldElement.input as DateTimePickerFormInput
+                    rememberDateTimeFieldState(
+                        field = fieldElement,
+                        minEpochMillis = input.min?.toEpochMilli(),
+                        maxEpochMillis = input.max?.toEpochMilli(),
+                        shouldShowTime = input.includeTime,
+                        form = form,
+                        scope = scope
+                    )
+                }
+
                 is ComboBoxFormInput -> {
                     rememberComboBoxFieldState(
                         field = fieldElement,

toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/components/FormElements.kt

@@ -3,7 +3,6 @@ package com.arcgismaps.toolkit.featureforms.components
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
-import androidx.compose.runtime.rememberCoroutineScope
 import com.arcgismaps.mapping.featureforms.ComboBoxFormInput
 import com.arcgismaps.mapping.featureforms.DateTimePickerFormInput
 import com.arcgismaps.mapping.featureforms.FeatureForm
@@ -20,31 +19,20 @@ import com.arcgismaps.toolkit.featureforms.components.text.FormTextField
 import com.arcgismaps.toolkit.featureforms.components.text.FormTextFieldState
 
 @Composable
-internal fun FieldElement(field: FieldFormElement, form: FeatureForm, state: BaseFieldState?) {
+internal fun FieldElement(field: FieldFormElement, state: BaseFieldState) {
     val visible by field.isVisible.collectAsState()
-    val scope = rememberCoroutineScope()
     if (visible) {
         when (field.input) {
             is TextBoxFormInput, is TextAreaFormInput -> {
-                state?.let {
-                    FormTextField(state = state as FormTextFieldState)
-                }
+                FormTextField(state = state as FormTextFieldState)
             }
 
             is DateTimePickerFormInput -> {
-                DateTimeField(
-                    state = DateTimeFieldState(
-                        formElement = field,
-                        form = form,
-                        scope = scope
-                    )
-                )
+                DateTimeField(state = state as DateTimeFieldState)
             }
 
             is ComboBoxFormInput -> {
-                state?.let {
-                    ComboBoxField(state = state as ComboBoxFieldState)
-                }
+                ComboBoxField(state = state as ComboBoxFieldState)
             }
 
             else -> { /* TO-DO: add support for other input types */

toolkit/featureforms/src/main/java/com/arcgismaps/toolkit/featureforms/components/datetime/DateTimeField.kt

@@ -66,7 +66,7 @@ internal fun DateTimeField(
 ) {
     val isEditable by state.isEditable.collectAsState()
     val isRequired by state.isRequired.collectAsState()
-    val epochMillis by state.value.collectAsState()
+    val epochMillis by state.epochMillis.collectAsState()
 
     val shouldShowTime = remember {
         state.shouldShowTime
@@ -151,7 +151,7 @@ internal fun DateTimeField(
                 trailingIcon = {
                     if (epochMillis != null) {
                         IconButton(
-                            onClick = { state.clearValue() },
+                            onClick = { state.onValueChanged("") },
                             modifier = Modifier.semantics {
                                 contentDescription = "Clear text button"
                             }
@@ -214,7 +214,7 @@ internal fun DateTimeField(
             onDismissRequest = { openDialog = false },
             onCancelled = { openDialog = false },
             onConfirmed = {
-                state.setValue(pickerState.selectedDateTimeMillis)
+                state.onValueChanged(pickerState.selectedDateTimeMillis.toString())
                 openDialog = false
             })
     }