From 75129eabb951209f67eb5d25558c36fadfcb40c1 Mon Sep 17 00:00:00 2001 From: Hudson Miears Date: Mon, 18 Dec 2023 20:33:20 +0200 Subject: [PATCH 1/2] add viewlabelproperties to sceneview' --- .../main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt b/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt index a308be80d..1e10a8cd9 100644 --- a/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt +++ b/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt @@ -40,6 +40,7 @@ import com.arcgismaps.mapping.view.SceneView import com.arcgismaps.mapping.view.SingleTapConfirmedEvent import com.arcgismaps.mapping.view.TwoPointerTapEvent import com.arcgismaps.mapping.view.UpEvent +import com.arcgismaps.mapping.view.ViewLabelProperties import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.launch @@ -48,6 +49,7 @@ import kotlinx.coroutines.launch * * @param modifier Modifier to be applied to the composable SceneView * @param arcGISScene the [ArcGISScene] to be rendered by this composable SceneView + * @param viewLabelProperties the [ViewLabelProperties] used by the composable MapView * @param onInteractingChanged lambda invoked when the user starts and ends interacting with the composable SceneView * @param onRotate lambda invoked when a user performs a rotation gesture on the composable SceneView * @param onScale lambda invoked when a user performs a pinch gesture on the composable SceneView @@ -64,6 +66,7 @@ import kotlinx.coroutines.launch public fun SceneView( modifier: Modifier = Modifier, arcGISScene: ArcGISScene? = null, + viewLabelProperties: ViewLabelProperties = ViewLabelProperties(), onInteractingChanged: ((isInteracting: Boolean) -> Unit)? = null, onRotate: ((RotationChangeEvent) -> Unit)? = null, onScale: ((ScaleChangeEvent) -> Unit)? = null, @@ -84,6 +87,7 @@ public fun SceneView( factory = { sceneView }, update = { it.scene = arcGISScene + it.labeling = viewLabelProperties }) DisposableEffect(Unit) { From 45de4b494e76449d9d62de19ac42a0810f199cb3 Mon Sep 17 00:00:00 2001 From: Hudson Miears Date: Mon, 18 Dec 2023 20:38:30 +0200 Subject: [PATCH 2/2] fix doc --- .../main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt b/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt index 1e10a8cd9..78854417d 100644 --- a/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt +++ b/toolkit/geo-compose/src/main/java/com/arcgismaps/toolkit/geocompose/SceneView.kt @@ -49,7 +49,7 @@ import kotlinx.coroutines.launch * * @param modifier Modifier to be applied to the composable SceneView * @param arcGISScene the [ArcGISScene] to be rendered by this composable SceneView - * @param viewLabelProperties the [ViewLabelProperties] used by the composable MapView + * @param viewLabelProperties the [ViewLabelProperties] used by the composable SceneView * @param onInteractingChanged lambda invoked when the user starts and ends interacting with the composable SceneView * @param onRotate lambda invoked when a user performs a rotation gesture on the composable SceneView * @param onScale lambda invoked when a user performs a pinch gesture on the composable SceneView