Skip to content

Don't include "Enabled" in the toggle's label #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yo1995 opened this issue Dec 15, 2023 · 1 comment
Open

Don't include "Enabled" in the toggle's label #321

yo1995 opened this issue Dec 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@yo1995
Copy link
Collaborator

yo1995 commented Dec 15, 2023

See #318 (comment)

Samples to fix:

image
@yo1995 yo1995 changed the title Don Don't include "Enabled" in the toggle's label Dec 15, 2023
@yo1995 yo1995 added the enhancement New feature or request label Dec 15, 2023
@CalebRas
Copy link
Collaborator

I should clarify that in most (if not all) cases, Enabled shouldn't be needed as a suffix. While I couldn't find any explicit recommendations in the HIG, a cursory glance at how switches are used in iOS shows that toggle labels typically do not include the state as part of the label. The state is a function of the switch itself and including it in the label is odd, especially for VoiceOver. If it must be included in the label, it should be static, ie. it shouldn't change depending on the label's state.

On Mac Catalyst, a toggle in a toolbar using the default formatting appears as a plain button with no dynamic indication of whether it is enabled/disabled. Using a dynamic suffix was the best idea I could come up with to remedy this. I agree, though, that it is probably not an optimal solution. Do you have any other ideas, or do you recommend just leaving the buttons static? @philium

Screen.Recording.2023-12-15.at.9.33.18.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants