Skip to content

Commit cb70c72

Browse files
authored
Merge pull request #823 from Esri/df/706
`FloorFilter` - Resolve `NavigationStack` incompatibility
2 parents b8287e3 + 2a07d61 commit cb70c72

File tree

3 files changed

+258
-320
lines changed

3 files changed

+258
-320
lines changed

Sources/ArcGISToolkit/Components/FloorFilter/FloorFilter.swift

+2-7
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ public struct FloorFilter: View {
122122
siteAndFacilitySelectorIsPresented.toggle()
123123
} label: {
124124
Image(systemName: "building.2")
125+
.accessibilityIdentifier("Floor Filter button")
125126
.padding(.toolkitDefault)
126127
.opacity(viewModel.isLoading ? .zero : 1)
127128
.overlay {
@@ -175,13 +176,7 @@ public struct FloorFilter: View {
175176
)
176177
}
177178

178-
/// A configured `SiteAndFacilitySelector` view.
179-
///
180-
/// The layering of the `SiteAndFacilitySelector` over a `RoundedRectangle` is needed to
181-
/// produce a rounded corners effect. We can not simply use `.esriBorder()` here because
182-
/// applying the `cornerRadius()` modifier on `SiteAndFacilitySelector`'s underlying
183-
/// `NavigationView` causes a rendering bug. This bug remains in iOS 16 with
184-
/// `NavigationStack` and has been reported to Apple as FB10034457.
179+
/// A configured `SiteAndFacilitySelector`.
185180
@ViewBuilder private var siteAndFacilitySelector: some View {
186181
if horizontalSizeClass == .compact {
187182
Color.clear

0 commit comments

Comments
 (0)