-
Notifications
You must be signed in to change notification settings - Fork 360
Possible future package structure #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Probably would be good to explicitly mention that you are proposing package change only to
*if we decide to provide support for additional servers, maybe |
Yea, I envisioned a simple package of And yea if we want to extract things that are not spring specific we can move that to |
Also we can probably rename the folders and publish the modules separately too. So we could have folders like
|
I prefer keeping current explicit names. Since we don't have that many modules atm I think it makes sense to publish them together. |
This could be less relevant if we helped the graphql-java team and split up their library: graphql-java/graphql-java#336 |
Closing for now until we see the need to change existing packages. Going forward we can continue to follow the same pattern we have today |
Uh oh!
There was an error while loading. Please reload this page.
Is your feature request related to a problem? Please describe.
We would like to add more logic to the graphql kotlin library in the future to take advantage of running a full kotlin schema and maybe even sharing some of the core graphql packages with client libraries.
Describe the solution you'd like
We should update the package path of the schema generator and prepare for having new packages
We may also want to update the path of
graphql-kotlin-schema-generator
to reserve the top level path for other thingsgraphql-kotlin-schema-generator
com.expediagroup.graphql.generator
graphql-kotlin-federation
com.expediagroup.graphql.federation
graphql-kotlin-spring-server
com.expediagroup.graphql.spring
graphql-kotlin-schema
*com.expediagroup.graphql.schema
*graphql-kotlin-server
*com.expediagroup.graphql.server
*graphql-kotlin-client
*com.expediagroup.graphql.client
** Future packages
Additional context
We currently have a few issues that we have mentioned extracting more logic from
graphql-java
to write it in a pure Kotlin implementationThe text was updated successfully, but these errors were encountered: