Skip to content

Bug: licensecheck fails to identify all licenses of docutils package #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicolaDonelli opened this issue Oct 19, 2022 · 3 comments
Closed
Assignees
Labels
question Further information is requested

Comments

@NicolaDonelli
Copy link
Contributor

NicolaDonelli commented Oct 19, 2022

I am publishing a python package, licensed with a MIT license, that depends on docutils == 0.17.1. According to its license page docutils is licensed as Public Domain, Python Software, BSD2 and GPL but it seems that licenscecheck fails to correctly parse the GPL and BSD2.

Reproducible example

OS: MacOS Monterey 12.6

Requirements file: requirements.txt

docutils==0.17.1

Project License: MIT

Command: python -m licensecheck --using 'requirements:requirements.txt'
Output:

WARN: 'GNU GENERAL PUBLIC LICENSE (GPL)' License not identified so falling back to NO_LICENSE
┌──────┬────────────────────┬──────────────────────────────┐
│Compat│      Package       │           License            │
├──────┼────────────────────┼──────────────────────────────┤
│  ❌  │docutils            │Public Domain, Python Software│
└──────┴────────────────────┴──────────────────────────────┘

Expected Output:

WARN: 'GNU GENERAL PUBLIC LICENSE (GPL)' License not identified so falling back to NO_LICENSE

┌──────┬────────────────────┬────────────────────────────────────────┐
│Compat│      Package       │           License                      │
├──────┼────────────────────┼────────────────────────────────────────┤
│  ❌  │docutils            │Public Domain, Python Software, GPL, BSD│
└──────┴────────────────────┴────────────────────────────────────────┘
@NicolaDonelli NicolaDonelli added the question Further information is requested label Oct 19, 2022
@NicolaDonelli NicolaDonelli changed the title licensecheck fails to identify all licenses of docutils package Question: licensecheck fails to identify all licenses of docutils package Oct 19, 2022
@NicolaDonelli NicolaDonelli changed the title Question: licensecheck fails to identify all licenses of docutils package Bug: licensecheck fails to identify all licenses of docutils package Oct 19, 2022
@NicolaDonelli
Copy link
Contributor Author

NicolaDonelli commented Oct 19, 2022

P.s. Sorry for having mistakenly labelled the issue as a question: I realised after publishing it that it could probably be better categorised as a bug but it seems I cannot change the label anymore...

@FredHappyface
Copy link
Member

Hi thanks for opening the issue. What is happening is that the terminal reporter/ formatter is cutting off the licenses to fit the table. Using --formatter markdown yields

python3 -m licensecheck --using 'requirements:requirements.txt;requirements_optional.txt' --format markdown > foo.md

image

@FredHappyface
Copy link
Member

Fixed in 2022.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants