ClassUtil.checkAndFixAccess: ignore errors re: setAccessible, it's very common in JPMS world

Author: stevenschlansker

src/main/java/tools/jackson/databind/util/ClassUtil.java

@@ -846,41 +846,32 @@ public static boolean checkAndFixAccess(Member member, boolean evenIfAlreadyPubl
         // We know all members are also accessible objects...
         AccessibleObject ao = (AccessibleObject) member;
 
-        // 14-Jan-2009, tatu: It seems safe and potentially beneficial to
-        //   always to make it accessible (latter because it will force
-        //   skipping checks we have no use for...), so let's always call it.
         try {
             // 15-Apr-2021, tatu: With JDK 14+ we will be hitting access limitations
             //    esp. wrt JDK types so let's change a bit
             final Class<?> declaringClass = member.getDeclaringClass();
             boolean isPublic = Modifier.isPublic(member.getModifiers())
                     && Modifier.isPublic(declaringClass.getModifiers());
             if (!isJDKClass(declaringClass) && (!isPublic || evenIfAlreadyPublic)) {
-                return ao.trySetAccessible();
+                ao.setAccessible(true);
+                return true;
             } else {
                 return isPublic;
             }
-        } catch (SecurityException se) {
-            // 17-Apr-2009, tatu: This can fail on platforms like
-            // Google App Engine); so let's only fail if we really needed it...
-            if (!ao.isAccessible()) {
-                Class<?> declClass = member.getDeclaringClass();
-                throw new IllegalArgumentException("Cannot access "+member+" (from class "+declClass.getName()
-                    +"; failed to set access: "+exceptionMessage(se));
-            }
-            // 14-Apr-2021, tatu: [databind#3118] Java 9/JPMS causes new fails...
-            //    But while our baseline is Java 8, must check name
-            return true;
-        } catch (RuntimeException se) {
-            if ("InaccessibleObjectException".equals(se.getClass().getSimpleName())) {
-                throw new IllegalArgumentException(String.format(
-"Failed to call `setAccess()` on %s '%s' (of class %s) due to `%s`, problem: %s",
-member.getClass().getSimpleName(), member.getName(),
-nameOf(member.getDeclaringClass()),
-se.getClass().getName(), se.getMessage()),
-                        se);
+        } catch (SecurityException e) {
+            return false;
+        } catch (RuntimeException e) {
+            // 2025-03-24, scs: Since Java module system, it is common to be unable to see
+            // members of other modules. We can't assume we can crack open arbitrary types anymore.
+            // We'd love to catch this more explicitly, but Android... >:(
+            if ("InaccessibleObjectException".equals(e.getClass().getSimpleName())) {
+                return false;
             }
-            throw se;
+            throw new IllegalArgumentException(String.format(
+                    "Failed to call `setAccess()` on %s '%s' (of class %s) due to `%s`, problem: %s",
+                    member.getClass().getSimpleName(), member.getName(),
+                    nameOf(member.getDeclaringClass()),
+                    e.getClass().getName(), e.getMessage()), e);
         }
     }