Comment out one failing test wrt #921: was assuming wrong things about static methods, type variables

Author: cowtowncoder

src/main/java/com/fasterxml/jackson/databind/introspect/AnnotatedCreatorCollector.java

@@ -28,9 +28,6 @@ final class AnnotatedCreatorCollector
 
     private final TypeResolutionContext _typeContext;
 
-    // @since 2.11.3
-    private final TypeFactory _typeFactory;
-
     /**
      * @since 2.11
      */
@@ -40,11 +37,10 @@ final class AnnotatedCreatorCollector
 
     private AnnotatedConstructor _defaultConstructor;
 
-    AnnotatedCreatorCollector(AnnotationIntrospector intr, TypeFactory tf,
+    AnnotatedCreatorCollector(AnnotationIntrospector intr,
             TypeResolutionContext tc, boolean collectAnnotations)
     {
         super(intr);
-        _typeFactory = tf;
         _typeContext = tc;
         _collectAnnotations = collectAnnotations;
     }
@@ -60,18 +56,18 @@ public static Creators collectCreators(AnnotationIntrospector intr,
                 && !ClassUtil.isJDKClass(type.getRawClass());
 
         // Constructor also always members of resolved class, parent == resolution context
-        return new AnnotatedCreatorCollector(intr, typeFactory, tc, checkClassAnnotations)
-                .collect(type, primaryMixIn);
+        return new AnnotatedCreatorCollector(intr, tc, checkClassAnnotations)
+                .collect(typeFactory, type, primaryMixIn);
     }
 
-    Creators collect(JavaType type, Class<?> primaryMixIn)
+    Creators collect(TypeFactory typeFactory, JavaType type, Class<?> primaryMixIn)
     {
     // 30-Apr-2016, tatu: [databind#1215]: Actually, while true, this does
     //   NOT apply to context since sub-class may have type bindings
 //        TypeResolutionContext typeContext = new TypeResolutionContext.Basic(_typeFactory, _type.getBindings());
 
         List<AnnotatedConstructor> constructors = _findPotentialConstructors(type, primaryMixIn);
-        List<AnnotatedMethod> factories = _findPotentialFactories(type, primaryMixIn);
+        List<AnnotatedMethod> factories = _findPotentialFactories(typeFactory, type, primaryMixIn);
 
         /* And then... let's remove all constructors that are deemed
          * ignorable after all annotations have been properly collapsed.
@@ -191,7 +187,8 @@ private List<AnnotatedConstructor> _findPotentialConstructors(JavaType type,
         return result;
     }
 
-    private List<AnnotatedMethod> _findPotentialFactories(JavaType type, Class<?> primaryMixIn)
+    private List<AnnotatedMethod> _findPotentialFactories(TypeFactory typeFactory,
+            JavaType type, Class<?> primaryMixIn)
     {
         List<Method> candidates = null;
 
@@ -216,7 +213,7 @@ private List<AnnotatedMethod> _findPotentialFactories(JavaType type, Class<?> pr
         //   passing that should not break things, it appears to... Regardless,
         //   it should not be needed or useful as those bindings are only available
         //   to non-static members
-        TypeResolutionContext typeResCtxt = new TypeResolutionContext.Empty(_typeFactory);
+        TypeResolutionContext typeResCtxt = new TypeResolutionContext.Empty(typeFactory);
 
         int factoryCount = candidates.size();
         List<AnnotatedMethod> result = new ArrayList<>(factoryCount);

src/test/java/com/fasterxml/jackson/databind/deser/builder/BuilderWithTypeParametersTest.java

@@ -57,6 +57,10 @@ public MyGenericPOJO<T> build() {
       }
     }
 
+    // 05-Sep-2020, tatu: This is not correct and cannot be made to work --
+    //   assumption is that static method binding `T` would somehow refer to
+    //   class type parameter `T`: this is not true.
+/*    
     public static class MyGenericPOJOWithCreator<T> {
       List<T> data;
 
@@ -86,6 +90,7 @@ public MyGenericPOJOWithCreator<T> build() {
           }
       }
     }
+    */
 
     public void testWithBuilderInferringBindings() throws Exception {
         final ObjectMapper mapper = jsonMapperBuilder()
@@ -113,6 +118,8 @@ public void testWithBuilderWithoutInferringBindings() throws Exception {
       assertEquals(LinkedHashMap.class, ob.getClass());
     }
 
+    // 05-Sep-2020, tatu: see above for reason why this can not work
+/*    
     public void testWithCreator() throws Exception {
       final ObjectMapper mapper = new ObjectMapper();
       final String json = aposToQuotes("{ 'data': [ { 'x': 'x', 'y': 'y' } ] }");
@@ -124,4 +131,5 @@ public void testWithCreator() throws Exception {
       assertNotNull(ob);
       assertEquals(MyPOJO.class, ob.getClass());
     }
-  }
+    */
+}