Make TokenBuffer(JsonParser, ObjectReadContext) constructor public

[sdeleuze]

I am working on adding support for Jackson 3 in Spring Framework 7.

We would need TokenBuffer(JsonParser, ObjectReadContext) to be public not just protected as we use it there.

I would also welcome guidance on how to get the required ObjectReadContext as ObjectMapper#_deserializationContext is documented as "only public to allow for testing".

[cowtowncoder]

@sdeleuze And this is for Jackson 3.0, right? So tools.jackson.databind.util.TokenBuffer.

Intent is to use factory method instead of contructor, there is:

public static TokenBuffer forBuffering(JsonParser p, ObjectReadContext ctxt) {

which is why constructor itself is protected (to allow factory method to perform whatever initialization might be needed in future).

As to ObjectReadContext: most usage is intended to go via DeserializationContext which has:

public TokenBuffer bufferForInputBuffering(JsonParser p) {

passing this as ObjectReadContext. But in general wherever code is to get a TokenBuffer, expectation is that DeserializationContext would be available; typically from ValueDeserializer or another handler to which one is passed. So usually it's part of deserialization processing workflow.

But if it is known that no calls are made that need the context, passing ObjectReadContext.empty() works fine. Many unit tests on jackson-core do that.

[sdeleuze]

Make sense, thanks for your feedback.

[sdeleuze]

See #5110 related issue.