-
-
Notifications
You must be signed in to change notification settings - Fork 151
support snakeyaml UnicodeReader #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd be -1 for adding configurability at this point. The original reason for But we still need to resolve #497 for CSV no matter what so would ideally target that first. |
I understand that CSV still has the 497 issue but since the UTF8Reader class is copied into the yaml, csv and toml modules there is a risk that all 3 are still affected in some cases. I might try to set up some jmh testing of the UTFReader against the Java InputStreamReader to see which is best. Ideally, Jackson shouldn't need special UTF8 decoding. We've seen with number writing that Java team sometimes does try to fix their perf issues. |
True, ideally we would not need plain UTF-8 decoding readers (as opposed to JSON codec where combination of decoding and tokenization is bigger win and makes more sense). I'd be bit more cautious about using UTF-8 reader from SnakeYAML fwtw; JDK version less so. |
Uh oh!
There was an error while loading. Please reload this page.
UTF8Reader
throws"Need to move partially decoded character; buffer not modifiable" when read only one chinese char #497)The text was updated successfully, but these errors were encountered: