From 9736551db0710eaeb172f3f713fb61e281cf359f Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Tue, 16 Mar 2021 13:23:43 -0400 Subject: [PATCH 1/2] Updated README to relfect RN 0.63+ support --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ddddfcbf..1c0b9bc7 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ [![Maintenance Status][maintenance-image]](#maintenance-status) ![Workflow Status](https://github.com/FormidableLabs/react-native-app-auth/actions/workflows/main.yml/badge.svg?branch=main) -This versions supports `react-native@0.60+`. The last pre-0.60 compatible version is [`v4.4.0`](https://github.com/FormidableLabs/react-native-app-auth/tree/v4.4.0). +This versions supports `react-native@0.63+`. The last pre-0.63 compatible version is [`v5.1.3`](https://github.com/FormidableLabs/react-native-app-auth/tree/v5.1.3). React Native bridge for [AppAuth-iOS](https://github.com/openid/AppAuth-iOS) and [AppAuth-Android](https://github.com/openid/AppAuth-Android) SDKS for communicating with From 2a0b486ea2701d3b6cf53ebfff2617858f670a76 Mon Sep 17 00:00:00 2001 From: Mansoor Siddeeq Date: Thu, 18 Mar 2021 15:44:04 -0400 Subject: [PATCH 2/2] updated READMEs to clarify reactnavigation deep linking android integration --- Example/README.md | 16 +++++++++++++++- README.md | 2 ++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/Example/README.md b/Example/README.md index 84ccbcbd..642921be 100644 --- a/Example/README.md +++ b/Example/README.md @@ -23,4 +23,18 @@ yarn npx react-native run-android ``` -Note that you have to have the emulator open before running the last command. If you have difficulty getting the emulator to connect, open the project from Android Studio and run it through there. +### Notes +* You have to have the emulator open before running the last command. If you have difficulty getting the emulator to connect, open the project from Android Studio and run it through there. +* ANDROID: When integrating with a project that utilizes deep linking (e.g. [React Navigation deep linking](https://reactnavigation.org/docs/deep-linking/#set-up-with-bare-react-native-projects)), update the redirectUrl in your config and the `appAuthRedirectScheme` value in build.gradle to use a custom scheme so that it differs from the scheme used in your deep linking intent-filter [as seen here](https://github.com/FormidableLabs/react-native-app-auth/issues/494#issuecomment-797394994). + +Example: +``` +// build.gradle +android { + defaultConfig { + manifestPlaceholders = [ + appAuthRedirectScheme: 'io.identityserver.demo.auth' + ] + } +} +``` diff --git a/README.md b/README.md index 1c0b9bc7..df158e77 100644 --- a/README.md +++ b/README.md @@ -408,6 +408,8 @@ android { The scheme is the beginning of your OAuth Redirect URL, up to the scheme separator (`:`) character. E.g. if your redirect uri is `com.myapp://oauth`, then the url scheme will is `com.myapp`. +NOTE: When integrating with [React Navigation deep linking](https://reactnavigation.org/docs/deep-linking/#set-up-with-bare-react-native-projects), be sure to make this scheme (and the scheme in the config's redirectUrl) unique from the scheme defined in the deep linking intent-filter. E.g. if the scheme in your intent-filter is set to `com.myapp`, then update the above scheme/redirectUrl to be `com.myapp.auth` [as seen here](https://github.com/FormidableLabs/react-native-app-auth/issues/494#issuecomment-797394994). + ## Usage ```javascript