Skip to content

Sidecar should have a livenessProbe per default #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johscheuer opened this issue May 5, 2021 · 0 comments · Fixed by #666
Closed

Sidecar should have a livenessProbe per default #661

johscheuer opened this issue May 5, 2021 · 0 comments · Fixed by #666
Labels
reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns
Milestone

Comments

@johscheuer
Copy link
Member

johscheuer commented May 5, 2021

Currently the sidecar only has a readinessProbe to check if the Python process already has started up we should additionally add a livenessProbe so that the container get's restarted when the Python process hangs. We've seen a few Python processes in the Sidecar that have stopped working and killing the process resolves the issue. With a livenessProbe we don't have to manually kill the process. For the livenessProbe I would propose a default periodSeconds of 30s and a failureThreshold of 2 which means after 2 minutes the container will be killed if not responding. We should add a field to enable this in the cluster spec and once we move to 1.0.0 we will make this the default.

@johscheuer johscheuer added the reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns label May 5, 2021
@johscheuer johscheuer added this to the 1.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reliability Protections against unsafe behavior, blockers go reconciliation, or other reliability concerns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant