Skip to content

Remove the readinessProbe for the sidecar #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johscheuer opened this issue May 7, 2021 · 3 comments
Closed

Remove the readinessProbe for the sidecar #668

johscheuer opened this issue May 7, 2021 · 3 comments
Labels
sidecar All issues/PR targeted for the sidecar

Comments

@johscheuer
Copy link
Member

In #666 we added support for a livenessProbe in the sidecar. before cutting the 1.0.0 release we want to remove the readinessProbe for the sidecar since we don't get any benefits of it (we always call directly the sidecar).

@johscheuer johscheuer added the sidecar All issues/PR targeted for the sidecar label May 7, 2021
@johscheuer johscheuer added this to the 1.0 milestone May 7, 2021
@brownleej
Copy link
Member

I think the smoothest way to handle this transition is:

  1. Introduce a new setting to enable the readiness probe, defaulting to true
  2. In the next major release, default that to false and deprecate it
  3. In the major release after that, remove the setting

This means we would need to go through two major releases to fully remove the code, but it means that there is no risk of a change to people's pod specs coming in a minor release.

@brownleej
Copy link
Member

We've already introduced the new setting, which is all we can do in the 1.0 release.

@brownleej brownleej removed this from the 1.0 milestone Jul 2, 2021
@brownleej
Copy link
Member

I think we can leave this as-is, until we have a broader sweep to remove support for the older sidecar model.

@brownleej brownleej closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sidecar All issues/PR targeted for the sidecar
Projects
None yet
Development

No branches or pull requests

2 participants