-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate countdown inside the player instead of static message ouside of the player when autoplay is enabled #1214
Comments
I tried to take a stab but the result is not good... Apr-22-2021.11-10-00.mp4Code change: |
The idea is good, I am not so sure however that it will work well because these toasts, as you might have noticed get pushed to the top. Maybe you could make the toast less than 1 second, so that it disappears before the next one occurs. Then the previous one does not get pushed upwards |
I think i worded wrong what i mean with integrate countdown into the player, because this implementation still occurs on the outside of the player. To clear things up i screen recored YT implementation. Z4YdRHIOef.mp4There has to be a countdown and cancel button. The other things like the preview of the next video and the play now button are optional. |
Yeah, I mean @PikachuEXE's approach is an easy approach which solves the problem with existing functionality. For the moment that would be fine. But in the long run, something like on YouTube will obviously be more pleasant to look at |
Hmm i dont think i can agree with u because of the flaws i pointed out in my issue. The proposed implementation of Pikachu is still outside of the player. This implementation wont fix the 3 flaws i pointed out. It is a requirement to implement it into to player to fix the flaws, so its not only for the looks. |
Adjusted the time for the messages to ensure there is no flashing effect (not sure the actual cause) Apr-27-2021.14-58-35.mp4 |
True that. But it is still an improvement over the current system. So I'd leave this open, even with @PikachuEXE changes |
#1234 opened |
@Svallinn @GilgusMaximus I would like u to reopen this issue because the problems i pointed out are not fixed with this merge. This is only a visual fix instead of fixing the real problems i pointed out. |
That's my bad. |
@PikachuEXE just noticed that the countdown continues to appear when i leave the video page. So lets say the countdown started and i go into the settings page i will see the countdown. I think its better to just cancel that message when the user goes out of the video page. |
@efb4f5ff-1298-471a-8973-3d47447115dc |
Is your feature request related to a usage problem (not a bug)? Please describe.
I noticed that there is a static message ("Playing next video in 5 seconds. Click to cancel.") when waiting for the next video to appear. I think its better to let the user know how much time they have left instead of just guessing when the 5sec will be over.
This will enhance user experience in 2 ways:
Describe the solution you'd like to see implemented
Integrate the countdown into the player.
This is because there are 3 flaws in the current implementation:
The text was updated successfully, but these errors were encountered: