fix(test): fail on php errors

Author: alquerci

Diff for: docker-compose.yml

@@ -28,6 +28,9 @@ services:
         {
           echo 'pdo_mysql.default_socket = /var/run/mysqld/mysql.sock'
           echo 'memory_limit = -1'
+          echo 'error_reporting = '`
+            php -r 'echo (E_ALL | E_STRICT) ^ E_USER_DEPRECATED ^ E_DEPRECATED ^ E_STRICT ^ E_USER_NOTICE ^ E_NOTICE;'
+          `
           echo 'short_open_tag = off'
           echo 'magic_quotes_gpc = off'
           echo 'date.timezone = "UTC"'
@@ -57,6 +60,9 @@ services:
         {
           echo 'pdo_mysql.default_socket = /var/run/mysqld/mysql.sock'
           echo 'memory_limit = -1'
+          echo 'error_reporting = '`
+            php -r 'echo (E_ALL | E_STRICT) ^ E_USER_DEPRECATED ^ E_DEPRECATED ^ E_STRICT ^ E_USER_NOTICE ^ E_NOTICE;'
+          `
           echo 'short_open_tag = off'
           echo 'magic_quotes_gpc = off'
           echo 'date.timezone = "UTC"'

Diff for: lib/vendor/lime/lime.php

@@ -42,7 +42,7 @@ public function __construct($plan = null, $options = array())
       'force_colors'    => false,
       'output'          => null,
       'verbose'         => false,
-      'error_reporting' => false,
+      'error_reporting' => true,
     ), $options);
 
     $this->output = $this->options['output'] ? $this->options['output'] : new lime_output($this->options['force_colors']);
@@ -140,6 +140,7 @@ public function __destruct()
     $plan = $this->results['stats']['plan'];
     $passed = count($this->results['stats']['passed']);
     $failed = count($this->results['stats']['failed']);
+    $errors = count($this->results['stats']['errors']);
     $total = $this->results['stats']['total'];
     is_null($plan) and $plan = $total and $this->output->echoln(sprintf("1..%d", $plan));
 
@@ -156,6 +157,10 @@ public function __destruct()
     {
       $this->output->red_bar(sprintf("# Looks like you failed %d tests of %d.", $failed, $passed + $failed));
     }
+    else if ($errors)
+    {
+      $this->output->red_bar(sprintf("# Looks like test pass but with %d errors.", $errors));
+    }
     else if ($total == $plan)
     {
       $this->output->green_bar("# Looks like everything went fine.");
@@ -174,10 +179,11 @@ private function getExitCode()
   {
     $plan = $this->results['stats']['plan'];
     $failed = count($this->results['stats']['failed']);
+    $errors = count($this->results['stats']['errors']);
     $total = $this->results['stats']['total'];
     is_null($plan) and $plan = $total and $this->output->echoln(sprintf("1..%d", $plan));
 
-    if ($failed)
+    if ($failed || $errors)
     {
       return 1;
     }
@@ -608,6 +614,12 @@ public function handle_error($code, $message, $file, $line, $context = null)
       case E_WARNING:
         $type = 'Warning';
         break;
+      case E_STRICT:
+        $type = 'Strict';
+        break;
+      case E_DEPRECATED:
+        $type = 'Deprecated';
+        break;
       default:
         $type = 'Notice';
         break;

Diff for: test/functional/fixtures/apps/cache/config/settings.yml

@@ -5,17 +5,15 @@ prod:
 
 dev:
   .settings:
-    # E_ALL | E_STRICT = 4095
-    error_reporting:        4095
+    error_reporting:        <?php echo (E_ALL | E_STRICT)."\n" ?>
     web_debug:              true
     cache:                  true
     no_script_name:         false
     etag:                   true
 
 test:
   .settings:
-    # E_ALL | E_STRICT = 4095
-    error_reporting:        4095
+    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_USER_DEPRECATED ^ E_DEPRECATED ^ E_STRICT ^ E_USER_NOTICE ^ E_NOTICE)."\n" ?>
     web_debug:              false
     cache:                  true
     no_script_name:         false

Diff for: test/functional/fixtures/apps/frontend/config/settings.yml

@@ -13,7 +13,7 @@ dev:
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_USER_DEPRECATED ^ E_DEPRECATED ^ E_STRICT ^ E_USER_NOTICE ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false

Diff for: test/functional/fixtures/apps/i18n/config/settings.yml

@@ -13,7 +13,7 @@ dev:
 
 test:
   .settings:
-    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_NOTICE)."\n" ?>
+    error_reporting:        <?php echo ((E_ALL | E_STRICT) ^ E_USER_DEPRECATED ^ E_DEPRECATED ^ E_STRICT ^ E_USER_NOTICE ^ E_NOTICE)."\n" ?>
     cache:                  false
     web_debug:              false
     no_script_name:         false