From 355392f6c5625c3c200b4de16be4d651f62ffd19 Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Sun, 26 Jan 2025 22:46:32 +0100 Subject: [PATCH 1/3] [ci] added php 8.4 --- .github/workflows/continuous-integration.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml index a6366b71b..cf02275f7 100644 --- a/.github/workflows/continuous-integration.yml +++ b/.github/workflows/continuous-integration.yml @@ -21,6 +21,7 @@ jobs: - "8.1" - "8.2" - "8.3" + - "8.4" memcached-version: - "1.6" From a1af14decccc885cb570306bf8bb0825768542ec Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Sun, 26 Jan 2025 23:01:03 +0100 Subject: [PATCH 2/3] PHP 8.4 > Removed deprecated constant E_STRICT, as it is not in use since PHP 5.4 anymore. --- lib/log/sfWebDebugLogger.class.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/log/sfWebDebugLogger.class.php b/lib/log/sfWebDebugLogger.class.php index d61c97dba..fe1779dae 100644 --- a/lib/log/sfWebDebugLogger.class.php +++ b/lib/log/sfWebDebugLogger.class.php @@ -56,8 +56,7 @@ public function initialize(sfEventDispatcher $dispatcher, $options = []) * PHP error handler send PHP errors to log. * * PHP user space error handler can not handle E_ERROR, E_PARSE, - * E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR, E_COMPILE_WARNING, - * and most of E_STRICT. + * E_CORE_ERROR, E_CORE_WARNING, E_COMPILE_ERROR and E_COMPILE_WARNING. * * @param string $errno the level of the error raised, as an integer * @param string $errstr the error message, as a string @@ -76,11 +75,6 @@ public function handlePhpError($errno, $errstr, $errfile, $errline, $errcontext $message = sprintf(' %%s at %s on line %s (%s)', $errfile, $errline, str_replace('%', '%%', $errstr)); switch ($errno) { - case E_STRICT: - $this->dispatcher->notify(new sfEvent($this, 'application.log', ['priority' => sfLogger::ERR, sprintf($message, 'Strict notice')])); - - break; - case E_NOTICE: $this->dispatcher->notify(new sfEvent($this, 'application.log', ['priority' => sfLogger::NOTICE, sprintf($message, 'Notice')])); From ab85e293aec90a3c37695ffee58da8e0e816c24a Mon Sep 17 00:00:00 2001 From: "Thomas A. Hirsch" Date: Mon, 27 Jan 2025 07:24:32 +0100 Subject: [PATCH 3/3] updated README.md to reflect supported php versions. --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9cf3d95cc..645635cac 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ All the enhancements and BC breaks are listed in the [WHATS_NEW](https://github. - [DIC](https://github.com/FriendsOfSymfony1/symfony1/wiki/ServiceContainer) - Composer support -- PHP 8.3 support +- PHP 8.4 support - performance boost - new widgets & validators - some tickets fixed from the symfony trac @@ -34,7 +34,7 @@ It runs on *nix and Windows platforms*. Requirements ------------ -PHP 5.3.4 and up. See prerequisites on https://symfony.com/legacy/doc/getting-started/1_4/en/02-Prerequisites +PHP 7.4 and up. See prerequisites on https://symfony.com/legacy/doc/getting-started/1_4/en/02-Prerequisites Installation ------------