Skip to content

Enable setting a static gas price via NodeConfig #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MujkicA opened this issue Jan 16, 2025 · 1 comment · May be fixed by #1668
Open

Enable setting a static gas price via NodeConfig #1581

MujkicA opened this issue Jan 16, 2025 · 1 comment · May be fixed by #1668
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MujkicA
Copy link
Contributor

MujkicA commented Jan 16, 2025

In addition to setting starting_gas_price the node also requires us to pass --gas-price-change-percent 0 for the set price to remain static. We should forward this parameter through our NodeConfig and update the can_setup_static_gas_price to test to verify that the price remains stable after producing a block.

@MujkicA MujkicA added the enhancement New feature or request label Jan 16, 2025
@hal3e hal3e added the good first issue Good for newcomers label Apr 11, 2025
@hal3e hal3e closed this as completed May 12, 2025
@hal3e hal3e reopened this May 12, 2025
@grandima grandima linked a pull request May 18, 2025 that will close this issue
4 tasks
@grandima
Copy link

grandima commented May 18, 2025

Hey @MujkicA could you please check my PR: #1668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants