Skip to content

Commit d4a972b

Browse files
AnemyFyko
authored andcommitted
util: remove unicode support todo for perf implications
PR-URL: nodejs#43762 Refs: nodejs#43721 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 0b3757d commit d4a972b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/internal/util/inspect.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,8 +1598,9 @@ function formatPrimitive(fn, value, ctx) {
15981598
trailer = `... ${remaining} more character${remaining > 1 ? 's' : ''}`;
15991599
}
16001600
if (ctx.compact !== true &&
1601-
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
1602-
// function.
1601+
// We do not support handling unicode characters width with
1602+
// the readline getStringWidth function as there are
1603+
// performance implications.
16031604
value.length > kMinLineLength &&
16041605
value.length > ctx.breakLength - ctx.indentationLvl - 4) {
16051606
return value

0 commit comments

Comments
 (0)