Fix lint warnings for pylint 2.10 (#1459)

Author: seisman

pygmt/helpers/tempfile.py

@@ -84,7 +84,7 @@ def read(self, keep_tabs=False):
         content : str
             Content of the temporary file as a Unicode string.
         """
-        with open(self.name) as tmpfile:
+        with open(self.name, mode="r", encoding="utf8") as tmpfile:
             content = tmpfile.read()
             if not keep_tabs:
                 content = content.replace("\t", " ")

pygmt/sphinx_gallery.py

@@ -24,7 +24,7 @@ def __call__(self, block, block_vars, gallery_conf):
         Called by sphinx-gallery to save the figures generated after running
         code.
         """
-        image_names = list()
+        image_names = []
         image_path_iterator = block_vars["image_path_iterator"]
         figures = SHOWED_FIGURES
         while figures:

pygmt/tests/test_helpers.py

@@ -93,7 +93,7 @@ def test_gmttempfile_read():
     Make sure GMTTempFile.read() works.
     """
     with GMTTempFile() as tmpfile:
-        with open(tmpfile.name, "w") as ftmp:
+        with open(tmpfile.name, "w", encoding="utf8") as ftmp:
             ftmp.write("in.dat: N = 2\t<1/3>\t<2/4>\n")
         assert tmpfile.read() == "in.dat: N = 2 <1/3> <2/4>\n"
         assert tmpfile.read(keep_tabs=True) == "in.dat: N = 2\t<1/3>\t<2/4>\n"

pygmt/tests/test_legend.py

@@ -93,7 +93,7 @@ def test_legend_specfile():
 """
 
     with GMTTempFile() as specfile:
-        with open(specfile.name, "w") as file:
+        with open(specfile.name, "w", encoding="utf8") as file:
             file.write(specfile_contents)
         fig = Figure()
         fig.basemap(projection="x6i", region=[0, 1, 0, 1], frame=True)

pygmt/tests/test_meca.py

@@ -169,7 +169,7 @@ def test_meca_spec_file():
     focal_mechanism = [-127.43, 40.81, 12, -3.19, 1.16, 3.93, -1.02, -3.93, -1.02, 23]
     # writes temp file to pass to gmt
     with GMTTempFile() as temp:
-        with open(temp.name, mode="w") as temp_file:
+        with open(temp.name, mode="w", encoding="utf8") as temp_file:
             temp_file.write(" ".join([str(x) for x in focal_mechanism]))
         # supply focal mechanisms to meca as a file
         fig.meca(

pygmt/tests/test_text.py

@@ -289,7 +289,7 @@ def test_text_angle_font_justify_from_textfile():
     """
     fig = Figure()
     with GMTTempFile(suffix=".txt") as tempfile:
-        with open(tempfile.name, "w") as tmpfile:
+        with open(tempfile.name, "w", encoding="utf8") as tmpfile:
             tmpfile.write("114 0.5 30 22p,Helvetica-Bold,black LM BORNEO")
         fig.text(
             region=[113, 117.5, -0.5, 3],

pygmt/tests/test_x2sys_cross.py

@@ -107,7 +107,9 @@ def test_x2sys_cross_input_two_dataframes(mock_x2sys_home):
         )
 
         # Add a time row to the x2sys fmtfile
-        with open(file=os.path.join(tmpdir, "xyz.fmt"), mode="a") as fmtfile:
+        with open(
+            file=os.path.join(tmpdir, "xyz.fmt"), mode="a", encoding="utf8"
+        ) as fmtfile:
             fmtfile.write("time\ta\tN\t0\t1\t0\t%g\n")
 
         # Create pandas.DataFrame track tables
@@ -164,7 +166,9 @@ def test_x2sys_cross_input_two_filenames(mock_x2sys_home):
         # Create temporary xyz files
         for i in range(2):
             np.random.seed(seed=i)
-            with open(os.path.join(os.getcwd(), f"track_{i}.xyz"), mode="w") as fname:
+            with open(
+                os.path.join(os.getcwd(), f"track_{i}.xyz"), mode="w", encoding="utf8"
+            ) as fname:
                 np.savetxt(fname=fname, X=np.random.rand(10, 3))
 
         output = x2sys_cross(

pygmt/tests/test_x2sys_init.py

@@ -29,7 +29,7 @@ def test_x2sys_init_region_spacing(mock_x2sys_home):
             tag=tag, fmtfile="xyz", force=True, region=[0, 10, 20, 30], spacing=[5, 5]
         )
 
-        with open(os.path.join(tmpdir, f"{tag}.tag"), "r") as tagpath:
+        with open(os.path.join(tmpdir, f"{tag}.tag"), "r", encoding="utf8") as tagpath:
             tail_line = tagpath.readlines()[-1]
             assert "-R0/10/20/30" in tail_line
             assert "-I5/5" in tail_line
@@ -50,7 +50,7 @@ def test_x2sys_init_units_gap(mock_x2sys_home):
             gap=["tseconds", "de"],
         )
 
-        with open(os.path.join(tmpdir, f"{tag}.tag"), "r") as tagpath:
+        with open(os.path.join(tmpdir, f"{tag}.tag"), "r", encoding="utf8") as tagpath:
             tail_line = tagpath.readlines()[-1]
             assert "-Nse -Nde" in tail_line
             assert "-Wtseconds -Wde" in tail_line

setup.py

@@ -13,7 +13,7 @@
 URL = "https://github.com/GenericMappingTools/pygmt"
 DESCRIPTION = "A Python interface for the Generic Mapping Tools"
 KEYWORDS = ""
-with open("README.rst") as f:
+with open("README.rst", "r", encoding="utf8") as f:
     LONG_DESCRIPTION = "".join(f.readlines())
 
 PACKAGES = find_packages(exclude=["doc"])