Skip to content

Commit 1a97a84

Browse files
GiteaBotsilverwind
andauthored
Fix JS error on compare page (go-gitea#23551) (go-gitea#23566)
Backport go-gitea#23551 by @silverwind Fix regression from go-gitea#23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content. <img width="1226" alt="Screenshot 2023-03-17 at 21 42 47" src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png"> Fixes go-gitea#23562 Co-authored-by: silverwind <[email protected]>
1 parent 420d015 commit 1a97a84

File tree

1 file changed

+15
-13
lines changed

1 file changed

+15
-13
lines changed

Diff for: web_src/js/features/repo-issue.js

+15-13
Original file line numberDiff line numberDiff line change
@@ -515,20 +515,22 @@ export function initRepoPullRequestReview() {
515515
const $panel = $reviewBtn.parent().find('.review-box-panel');
516516
const $closeBtn = $panel.find('.close');
517517

518-
const tippy = createTippy($reviewBtn[0], {
519-
content: $panel[0],
520-
placement: 'bottom',
521-
trigger: 'click',
522-
role: 'menu',
523-
maxWidth: 'none',
524-
interactive: true,
525-
hideOnClick: true,
526-
});
518+
if ($reviewBtn.length && $panel.length) {
519+
const tippy = createTippy($reviewBtn[0], {
520+
content: $panel[0],
521+
placement: 'bottom',
522+
trigger: 'click',
523+
role: 'menu',
524+
maxWidth: 'none',
525+
interactive: true,
526+
hideOnClick: true,
527+
});
527528

528-
$closeBtn.on('click', (e) => {
529-
e.preventDefault();
530-
tippy.hide();
531-
});
529+
$closeBtn.on('click', (e) => {
530+
e.preventDefault();
531+
tippy.hide();
532+
});
533+
}
532534

533535
$(document).on('click', 'a.add-code-comment', async function (e) {
534536
if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745

0 commit comments

Comments
 (0)