Skip to content

Commit 3a63c68

Browse files
committed
Actually build gix to check MSRV
This changes `cargo check` commands to `cargo build` in the `ci-check-msrv` recipe in the `justfile`, which the `check-msrv` CI jobs in `msrv.yml` use. (It updates a CI step name accordingly.) The idea is to make sure at least `gix`, with the two combinations of features tested, actually *builds* under the MSRV toolchain. As in f10f18d, this also updates the `Makefile` rule corresponding to that `justfile` recipe. The idea of actually building was suggested in: #1808 (comment) However, this does not uncover any new breakages. And there has been further improvement on #1808, including in the commits leading up to this, as well as earlier, in 569c186 (#1909). Nonetheless, it seems likely that some problems remain with some combinations of crates and features that are not currently exercised in the MSRV check. #1808 is most likely not yet fully fixed.
1 parent dc1d271 commit 3a63c68

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

.github/workflows/msrv.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,5 +45,5 @@ jobs:
4545
run: |
4646
# TODO(msrv): Use `cargo update --minimal-versions` when `--minimal-versions` is available.
4747
cargo +nightly update -Zminimal-versions
48-
- name: Run some `cargo check` commands on `gix`
48+
- name: Run some `cargo build` commands on `gix`
4949
run: just ci-check-msrv

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ bench-gix-config:
126126

127127
check-msrv-on-ci: ## Check the minimal support rust version for currently installed Rust version
128128
rustc --version
129-
cargo check --locked --package gix
130-
cargo check --locked --package gix --no-default-features --features async-network-client,max-performance
129+
cargo build --locked --package gix
130+
cargo build --locked --package gix --no-default-features --features async-network-client,max-performance
131131

132132
##@ Maintenance
133133

justfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,8 @@ check-size:
246246
# Check the MSRV, *if* the toolchain is set and `Cargo.lock` is downgraded (used on CI)
247247
ci-check-msrv:
248248
rustc --version
249-
cargo check --locked -p gix
250-
cargo check --locked -p gix --no-default-features --features async-network-client,max-performance
249+
cargo build --locked -p gix
250+
cargo build --locked -p gix --no-default-features --features async-network-client,max-performance
251251

252252
# Enter a nix-shell able to build on macOS
253253
nix-shell-macos:

0 commit comments

Comments
 (0)