rename 'pretty' target into 'max', a better fit for what it is

Author: Byron

Diff for: Cargo.toml

@@ -22,8 +22,8 @@ test = false
 doctest = false
 
 [features]
-default = ["pretty"]
-pretty = ["fast", "pretty-cli"]
+default = ["max"]
+max = ["fast", "pretty-cli"]
 lean = ["fast", "lean-cli"]
 small = ["lean-cli"]
 

Diff for: Makefile

@@ -13,7 +13,7 @@ interactive-developer-environment-in-docker: ## Use docker for all dependencies
 
 ##@ Release Builds
 
-release-default: always ## the default build, big bug pretty (builds in ~2min 35s)
+release-default: always ## the default build, big but pretty (builds in ~2min 35s)
 	cargo build --release
 
 release-lean: always ## lean and fast (builds in ~1min 10s)
@@ -45,8 +45,8 @@ check: ## Build all code in suitable configurations
 	cargo check --all
 	cargo check --all --all-features
 	cargo check --no-default-features --features small
-	cargo check --no-default-features --features pretty
 	cargo check --no-default-features --features lean
+	cargo check --no-default-features --features max
 	cd gitoxide-core && cargo check --all-features
 	cd git-object && cargo check --all-features
 	cd git-odb && cargo check --all-features
@@ -60,9 +60,9 @@ unit-tests: ## run all unit tests
 continuous-unit-tests: ## run all unit tests whenever something changes
 	watchexec -w src $(MAKE) unit-tests
 
-journey-tests: always  ## run stateless journey tests (pretty-cli)
+journey-tests: always  ## run stateless journey tests (max)
 	cargo build
-	./tests/stateless-journey.sh target/debug/gio target/debug/giop pretty
+	./tests/stateless-journey.sh target/debug/gio target/debug/giop max
 
 journey-tests-small: always ## run stateless journey tests (lean-cli)
 	cargo build --no-default-features --features small

Diff for: src/plumbing/pretty.rs

@@ -12,7 +12,7 @@ mod options {
     use structopt::{clap::AppSettings, StructOpt};
 
     #[derive(Debug, StructOpt)]
-    #[structopt(name = "gio-plumbing", about = "The pretty git underworld")]
+    #[structopt(name = "gio-plumbing", about = "The git underworld")]
     #[structopt(settings = &[AppSettings::SubcommandRequired,
                         AppSettings::ColoredHelp])]
     pub struct Args {

Diff for: src/porcelain/pretty.rs

@@ -6,7 +6,7 @@ mod options {
     use structopt::{clap::AppSettings, StructOpt};
 
     #[derive(Debug, StructOpt)]
-    #[structopt(about = "The pretty git")]
+    #[structopt(about = "The git")]
     #[structopt(settings = &[AppSettings::SubcommandRequired,
                         AppSettings::ColoredHelp])]
     pub struct Args {

Diff for: tests/stateless-journey.sh

@@ -69,7 +69,7 @@ title "CLI ${kind}"
           expect_run $SUCCESSFULLY "$exe_plumbing" verify-pack --statistics "$PACK_INDEX_FILE"
         }
       )
-      if test "$kind" = pretty; then
+      if test "$kind" = "max"; then
       (with "statistics (JSON)"
         it "verifies the pack index successfully and with desired output" && {
           WITH_SNAPSHOT="$snapshot/plumbing-verify-pack-index-with-statistics-json-success" \