fix: hanging Read implementation of pipeline::convert::ToGitOutcome.

This codepath was never tested and its function more subtle than one could have known.
Also fix incorrect configuration handling which could lead to binary files with `text=auto`
to be identified as text, which would then require conversion.

Author: Byron

Diff for: gix-filter/src/pipeline/convert.rs

@@ -315,7 +315,7 @@ where
         match self {
             ToGitOutcome::Unchanged(r) => r.read(buf),
             ToGitOutcome::Process(r) => r.read(buf),
-            ToGitOutcome::Buffer(mut r) => r.read(buf),
+            ToGitOutcome::Buffer(r) => r.read(buf),
         }
     }
 }

Diff for: gix-filter/src/pipeline/util.rs

@@ -170,7 +170,7 @@ impl<'driver> Configuration<'driver> {
         let attr_digest = digest;
         digest = match digest {
             None => Some(config.auto_crlf.into()),
-            Some(AttributesDigest::TextAuto) => Some(config.to_eol().into()),
+            Some(AttributesDigest::Text) => Some(config.to_eol().into()),
             _ => digest,
         };
 

Diff for: gix-filter/tests/pipeline/convert_to_git.rs

@@ -19,7 +19,7 @@ fn no_driver_but_filter_with_autocrlf() -> gix_testtools::Result {
         )
     })?;
 
-    let out = pipe.convert_to_git(
+    let mut out = pipe.convert_to_git(
         "hi\r\n".as_bytes(),
         Path::new("any.txt"),
         &mut |_path, _attrs| {},
@@ -31,6 +31,9 @@ fn no_driver_but_filter_with_autocrlf() -> gix_testtools::Result {
         "hi\n",
         "the read is read into memory if there is no driver"
     );
+    let mut buf = Vec::new();
+    out.read_to_end(&mut buf)?;
+    assert_eq!(buf.as_bstr(), "hi\n", "we can consume the output");
     Ok(())
 }