some TODOs related to precomposed unicode on MacOS (#364)

Byron · Byron · commit bc246aaa81cd · 2022-04-07T12:52:17.000+08:00
diff --git a/git-repository/src/config.rs b/git-repository/src/config.rs
@@ -26,6 +26,7 @@ pub(crate) struct Cache {
     pub object_hash: git_hash::Kind,
     /// If true, multi-pack indices, whether present or not, may be used by the object database.
     pub use_multi_pack_index: bool,
+    // TODO: make core.precomposeUnicode available as well.
 }
 
 mod cache {
diff --git a/git-repository/src/repository/location.rs b/git-repository/src/repository/location.rs
@@ -9,7 +9,7 @@ impl crate::Repository {
         self.work_tree.as_deref()
     }
 
-    // TODO: tests
+    // TODO: tests, respect precomposeUnicode
     /// The directory of the binary path of the current process.
     pub fn install_dir(&self) -> std::io::Result<std::path::PathBuf> {
         std::env::current_exe().and_then(|exe| {

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ pub(crate) struct Cache {`
`26`	`26`	`pub object_hash: git_hash::Kind,`
`27`	`27`	`/// If true, multi-pack indices, whether present or not, may be used by the object database.`
`28`	`28`	`pub use_multi_pack_index: bool,`
	`29`	`+ // TODO: make core.precomposeUnicode available as well.`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`mod cache {`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ impl crate::Repository {`
`9`	`9`	`self.work_tree.as_deref()`
`10`	`10`	`}`
`11`	`11`
`12`		`- // TODO: tests`
	`12`	`+ // TODO: tests, respect precomposeUnicode`
`13`	`13`	`/// The directory of the binary path of the current process.`
`14`	`14`	`pub fn install_dir(&self) -> std::io::Result<std::path::PathBuf> {`
`15`	`15`	`std::env::current_exe().and_then(\|exe\| {`