Skip to content

Commit dc1d271

Browse files
committed
doc: Fix accessibility bug in MSRV badge
The SVG badge showing the project's MSRV, `etc/msrv-badge.svg`, has four occurrences of the MSRV in it. Three had the current intended MSRV. But the top-level `svg` element's `aria-label` attribute still had the value `rustc: 1.70.0+`, having not been updated the most recent two times the badge SVG was adjusted for a new MSRV. That would, at least potentially, result in screen readers and possibly other software saying/outputting 1.70.0 instead of 1.75.0. This changes the `aria-label` value to `rustc: 1.75.0+`, as intended. This also rephrases the comment in `msrv.yml` about updating the badge when changing the MSRV, to mention the need to change "all occurrences". (We may want to add a CI check to make sure the badge is fully consistent with the current MSRV, but that isn't attempted here.)
1 parent eaecc9b commit dc1d271

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/msrv.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ jobs:
2929
runs-on: ${{ matrix.os }}
3030

3131
env:
32-
# dictated by `firefox` to support the `helix` editor, but now probably effectively be controlled by `jiff`, which also aligns with `regex`.
33-
# IMPORTANT: adjust etc/msrv-badge.svg as well
32+
# This is dictated by `firefox` to support the `helix` editor, but now probably effectively
33+
# be controlled by `jiff`, which also aligns with `regex`.
34+
# IMPORTANT: When adjusting, change all occurrences in `etc/msrv-badge.svg` as well.
3435
RUST_VERSION: 1.75.0
3536

3637
steps:

etc/msrv-badge.svg

+1-1
Loading

0 commit comments

Comments
 (0)