fix lints for nightly, and clippy

Author: Byron

Diff for: .github/workflows/ci.yml

@@ -47,18 +47,18 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
-    - uses: dtolnay/rust-toolchain@stable
-    - uses: Swatinem/rust-cache@v2
-    - name: Setup dependencies
-      run:
-        sudo apt-get install tree
-    - uses: extractions/setup-just@v1
-    - name: test
-      env:
-        CI: true
-        GITOXIDE_TEST_IGNORE_ARCHIVES: 1
-      run: just ci-test
+      - uses: actions/checkout@v3
+      - uses: dtolnay/rust-toolchain@stable
+      - uses: Swatinem/rust-cache@v2
+      - name: Setup dependencies
+        run:
+          sudo apt-get install tree
+      - uses: extractions/setup-just@v1
+      - name: test
+        env:
+          CI: true
+          GITOXIDE_TEST_IGNORE_ARCHIVES: 1
+        run: just ci-test
 
   test-fast:
     strategy:
@@ -163,7 +163,7 @@ jobs:
           components: clippy,rustfmt
       - uses: extractions/setup-just@v1
       - name: Run cargo clippy
-        run: just clippy -D warnings
+        run: just clippy -D warnings -A unknown-lints
       - name: Run cargo doc
         run: just doc
       - name: Run cargo fmt
@@ -189,10 +189,10 @@ jobs:
     continue-on-error: ${{ matrix.checks == 'advisories' }}
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: EmbarkStudios/cargo-deny-action@v1
-      with:
-        command: check ${{ matrix.checks }}
+      - uses: actions/checkout@v3
+      - uses: EmbarkStudios/cargo-deny-action@v1
+        with:
+          command: check ${{ matrix.checks }}
   wasm:
     name: WebAssembly
     runs-on: ubuntu-latest

Diff for: gitoxide-core/src/repository/credential.rs

@@ -1,5 +1,3 @@
-use std::convert::TryInto;
-
 #[derive(Debug, thiserror::Error)]
 enum Error {
     #[error(transparent)]

Diff for: gix-actor/src/lib.rs

@@ -22,6 +22,7 @@ use gix_date::Time;
 
 mod identity;
 ///
+#[allow(clippy::empty_docs)]
 pub mod signature;
 
 /// A person with name and email.

Diff for: gix-actor/src/signature/mod.rs

@@ -129,5 +129,6 @@ pub(crate) mod write {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode;
 pub use decode::function::decode;

Diff for: gix-attributes/src/lib.rs

@@ -13,14 +13,18 @@ use kstring::{KString, KStringRef};
 
 mod assignment;
 ///
+#[allow(clippy::empty_docs)]
 pub mod name;
 ///
+#[allow(clippy::empty_docs)]
 pub mod state;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod search;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod parse;
 
 /// Parse attribute assignments line by line from `bytes`, and fail the operation on error.

Diff for: gix-attributes/src/search/outcome.rs

@@ -26,7 +26,7 @@ impl Outcome {
             for (order, macro_attributes) in collection.iter().filter_map(|(_, meta)| {
                 (!meta.macro_attributes.is_empty()).then_some((meta.id.0, &meta.macro_attributes))
             }) {
-                self.matches_by_id[order].macro_attributes = macro_attributes.clone()
+                self.matches_by_id[order].macro_attributes.clone_from(macro_attributes)
             }
 
             for (name, id) in self.selected.iter_mut().filter(|(_, id)| id.is_none()) {
@@ -88,7 +88,7 @@ impl Outcome {
     /// Note that it's safe to call it multiple times, so that it can be called after this instance was used to store a search result.
     pub fn copy_into(&self, collection: &MetadataCollection, dest: &mut Self) {
         dest.initialize(collection);
-        dest.matches_by_id = self.matches_by_id.clone();
+        dest.matches_by_id.clone_from(&self.matches_by_id);
         if dest.patterns.len() != self.patterns.len() {
             dest.patterns = self.patterns.clone();
         }
@@ -325,7 +325,11 @@ impl MetadataCollection {
         };
 
         self.assign_order_to_attributes(attrs);
-        self.name_to_meta.get_mut(name).expect("just added").macro_attributes = attrs.clone();
+        self.name_to_meta
+            .get_mut(name)
+            .expect("just added")
+            .macro_attributes
+            .clone_from(attrs);
 
         order
     }

Diff for: gix-bitmap/src/ewah.rs

@@ -1,6 +1,5 @@
-use std::convert::TryInto;
-
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode {
     /// The error returned by [`decode()`][super::decode()].
     #[derive(Debug, thiserror::Error)]
@@ -52,8 +51,6 @@ pub fn decode(data: &[u8]) -> Result<(Vec, &[u8]), decode::Error> {
 }
 
 mod access {
-    use std::convert::{TryFrom, TryInto};
-
     use super::Vec;
 
     impl Vec {

Diff for: gix-bitmap/src/lib.rs

@@ -7,8 +7,6 @@
 pub mod ewah;
 
 pub(crate) mod decode {
-    use std::convert::TryInto;
-
     #[inline]
     pub(crate) fn split_at_pos(data: &[u8], pos: usize) -> Option<(&[u8], &[u8])> {
         if data.len() < pos {

Diff for: gix-chunk/src/file/decode.rs

@@ -1,4 +1,4 @@
-use std::{convert::TryInto, ops::Range};
+use std::ops::Range;
 
 mod error {
     /// The value returned by [`crate::file::Index::from_bytes()`]

Diff for: gix-chunk/src/file/index.rs

@@ -3,6 +3,7 @@ use std::ops::Range;
 use crate::file::Index;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod offset_by_kind {
     use std::fmt::{Display, Formatter};
 
@@ -27,6 +28,7 @@ pub mod offset_by_kind {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod data_by_kind {
     /// The error returned by [`Index::data_by_id()`][super::Index::data_by_id()].
     #[derive(Debug, thiserror::Error)]

Diff for: gix-chunk/src/file/mod.rs

@@ -1,9 +1,12 @@
 ///
+#[allow(clippy::empty_docs)]
 pub mod decode;
 ///
+#[allow(clippy::empty_docs)]
 pub mod index;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod write;
 
 /// The offset to a chunk as seen relative to the beginning of the file containing it.

Diff for: gix-chunk/src/lib.rs

@@ -10,8 +10,9 @@ pub type Id = [u8; 4];
 pub const SENTINEL: Id = [0u8; 4];
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod range {
-    use std::{convert::TryInto, ops::Range};
+    use std::ops::Range;
 
     use crate::file;
 
@@ -33,4 +34,5 @@ pub mod range {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod file;

Diff for: gix-command/src/lib.rs

@@ -330,6 +330,7 @@ pub fn extract_interpreter(executable: &Path) -> Option<shebang::Data> {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod shebang {
     use bstr::{BStr, ByteSlice};
     use std::ffi::OsString;

Diff for: gix-commitgraph/src/file/access.rs

@@ -1,5 +1,4 @@
 use std::{
-    convert::TryInto,
     fmt::{Debug, Formatter},
     path::Path,
 };

Diff for: gix-commitgraph/src/file/commit.rs

@@ -1,6 +1,5 @@
 //! Low-level operations on individual commits.
 use std::{
-    convert::TryInto,
     fmt::{Debug, Formatter},
     slice::Chunks,
 };

Diff for: gix-commitgraph/src/file/init.rs

@@ -1,8 +1,5 @@
+use std::path::Path;
 use std::path::PathBuf;
-use std::{
-    convert::{TryFrom, TryInto},
-    path::Path,
-};
 
 use bstr::ByteSlice;
 use memmap2::Mmap;

Diff for: gix-commitgraph/src/init.rs

@@ -1,5 +1,4 @@
 use std::{
-    convert::TryFrom,
     io::{BufRead, BufReader},
     path::{Path, PathBuf},
 };

Diff for: gix-commitgraph/src/lib.rs

@@ -51,6 +51,7 @@ pub fn at(path: impl AsRef<Path>) -> Result<Graph, init::Error> {
 mod access;
 pub mod file;
 ///
+#[allow(clippy::empty_docs)]
 pub mod init;
 pub mod verify;
 

Diff for: gix-commitgraph/src/verify.rs

@@ -2,7 +2,6 @@
 use std::{
     cmp::{max, min},
     collections::BTreeMap,
-    convert::TryInto,
     path::PathBuf,
 };
 

Diff for: gix-commitgraph/tests/commitgraph.rs

@@ -1,6 +1,5 @@
 use std::{
     collections::{HashMap, HashSet},
-    convert::{TryFrom, TryInto},
     hash::BuildHasher,
     io::{BufRead, Cursor},
     path::Path,

Diff for: gix-config-value/src/boolean.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, convert::TryFrom, ffi::OsString, fmt::Display};
+use std::{borrow::Cow, ffi::OsString, fmt::Display};
 
 use bstr::{BStr, BString, ByteSlice};
 

Diff for: gix-config-value/src/color.rs

@@ -1,5 +1,5 @@
 #![allow(missing_docs)]
-use std::{borrow::Cow, convert::TryFrom, fmt::Display, str::FromStr};
+use std::{borrow::Cow, fmt::Display, str::FromStr};
 
 use bstr::{BStr, BString};
 

Diff for: gix-config-value/src/integer.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, convert::TryFrom, fmt::Display, str::FromStr};
+use std::{borrow::Cow, fmt::Display, str::FromStr};
 
 use bstr::{BStr, BString};
 

Diff for: gix-config-value/src/lib.rs

@@ -37,10 +37,13 @@ impl Error {
 
 mod boolean;
 ///
+#[allow(clippy::empty_docs)]
 pub mod color;
 ///
+#[allow(clippy::empty_docs)]
 pub mod integer;
 ///
+#[allow(clippy::empty_docs)]
 pub mod path;
 
 mod types;

Diff for: gix-config-value/src/path.rs

@@ -5,6 +5,7 @@ use bstr::BStr;
 use crate::Path;
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod interpolate {
     use std::path::PathBuf;
 

Diff for: gix-config-value/tests/value/boolean.rs

@@ -1,5 +1,3 @@
-use std::convert::TryFrom;
-
 use gix_config_value::Boolean;
 
 use crate::b;

Diff for: gix-config-value/tests/value/color.rs

@@ -110,8 +110,6 @@ mod attribute {
 }
 
 mod from_git {
-    use std::convert::TryFrom;
-
     use bstr::BStr;
     use gix_config_value::Color;
 

Diff for: gix-config-value/tests/value/integer.rs

@@ -1,5 +1,3 @@
-use std::convert::TryFrom;
-
 use gix_config_value::{integer::Suffix, Integer};
 
 use crate::b;

Diff for: gix-config/benches/large_config_file.rs

@@ -1,5 +1,3 @@
-use std::convert::TryFrom;
-
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use gix_config::{parse::Events, File};
 

Diff for: gix-config/src/file/access/comfort.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, convert::TryFrom};
+use std::borrow::Cow;
 
 use bstr::BStr;
 

Diff for: gix-config/src/file/access/raw.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, collections::HashMap, convert::TryInto};
+use std::{borrow::Cow, collections::HashMap};
 
 use bstr::BStr;
 use smallvec::ToSmallVec;

Diff for: gix-config/src/file/access/read_only.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, convert::TryFrom};
+use std::borrow::Cow;
 
 use bstr::{BStr, ByteSlice};
 use gix_features::threading::OwnShared;

Diff for: gix-config/src/file/impls.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Cow, convert::TryFrom, fmt::Display, str::FromStr};
+use std::{borrow::Cow, fmt::Display, str::FromStr};
 
 use bstr::{BStr, BString, ByteVec};
 

Diff for: gix-config/src/file/includes/types.rs

@@ -115,6 +115,7 @@ impl Default for Options<'_> {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod conditional {
     /// Options to handle conditional includes like `includeIf.<condition>.path`.
     #[derive(Clone, Copy, Default)]

Diff for: gix-config/src/file/init/comfort.rs

@@ -141,6 +141,7 @@ impl File<'static> {
 }
 
 ///
+#[allow(clippy::empty_docs)]
 pub mod from_git_dir {
     use crate::file::init;
 

Diff for: gix-config/src/file/init/from_env.rs

@@ -1,5 +1,3 @@
-use std::convert::TryFrom;
-
 use bstr::{BStr, ByteSlice};
 
 use crate::{file, file::init, parse, parse::section, path::interpolate, File};

Diff for: gix-config/src/file/init/mod.rs

@@ -10,8 +10,10 @@ pub use types::{Error, Options};
 
 mod comfort;
 ///
+#[allow(clippy::empty_docs)]
 pub mod from_env;
 ///
+#[allow(clippy::empty_docs)]
 pub mod from_paths;
 
 impl<'a> File<'a> {