Skip to content

TRACE format is wrong #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreibarabas opened this issue Nov 20, 2024 · 1 comment
Closed

TRACE format is wrong #656

andreibarabas opened this issue Nov 20, 2024 · 1 comment
Assignees

Comments

@andreibarabas
Copy link

According to the google cloud docs, the trace format needs to be projects/[PROJECT-ID]/traces/[TRACE-ID]

Screenshot 2024-11-20 at 12 34 43

But currently it's only set to traceId

https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/28b1c300240771720f70a95522ede7ce6a2ccea0/src/logger.ts#L170C6-L170C33

@liuyunnnn
Copy link
Contributor

Hi,

Thanks for reporting this issue. You're right, we removed the trace field from the log in version 3.4.5 because function framework was unable to retrieve project id from the request. You can sill manually add this field by following the steps outlined in our documentation: https://cloud.google.com/functions/docs/monitoring/logging#writing_structured_logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants