Skip to content

Commit 03fa821

Browse files
chore(docs): Update PR template with missing steps (#3156)
[Per discussion](#3143 (comment)) we should make sure that users don't miss workflow generation when creating a new folder. Moreover a missing CODEOWNERS step was added here as well. Co-authored-by: Karl Weinmeister <[email protected]>
1 parent e28a762 commit 03fa821

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,7 @@ Note: Before submitting a pull request, please open an issue for discussion if y
1010
- [ ] **Lint** pass: `npm run lint` (see [Style](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#style))
1111
- [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
1212
- [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
13+
- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CODEOWNERS) with the codeowners for this sample
14+
- [ ] This sample adds a new sample directory, and I created [GitHub Actions workflow](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#adding-new-samples) for this sample
1315
- [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample
14-
- [ ] Please **merge** this PR for me once it is approved
16+
- [ ] Please **merge** this PR for me once it is approved

0 commit comments

Comments
 (0)