You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore(docs): Update PR template with missing steps (#3156)
[Per discussion](#3143 (comment)) we should make sure that users don't miss workflow generation when creating a new folder. Moreover a missing CODEOWNERS step was added here as well.
Co-authored-by: Karl Weinmeister <[email protected]>
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-1
Original file line number
Diff line number
Diff line change
@@ -10,5 +10,7 @@ Note: Before submitting a pull request, please open an issue for discussion if y
10
10
-[ ]**Lint** pass: `npm run lint` (see [Style](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#style))
11
11
-[ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones)
12
12
-[ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones)
13
+
-[ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CODEOWNERS) with the codeowners for this sample
14
+
-[ ] This sample adds a new sample directory, and I created [GitHub Actions workflow](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#adding-new-samples) for this sample
13
15
-[ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample
14
-
-[ ] Please **merge** this PR for me once it is approved
16
+
-[ ] Please **merge** this PR for me once it is approved
0 commit comments