Skip to content

Commit 0822b53

Browse files
authored
fix(tests): run/logging-manual test failures (#1637) (#1680)
Fixes #1637 run/logging-manual tests started failing due to a compatibility break in upgrading to `got v10` #1557. This was not caught because the broken `got` feature is only used in system tests.
1 parent 3692a10 commit 0822b53

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

run/logging-manual/README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ For more details on how to work with this sample read the [Google Cloud Run Node
1010

1111
### `npm run e2e-test`
1212

13-
```
13+
```sh
1414
export SERVICE_NAME=logging-manual
1515
export CONTAINER_IMAGE=gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual
1616
npm run e2e-test
@@ -69,4 +69,3 @@ test/runner.sh sleep 20
6969
[compute metadata server](https://cloud.google.com/compute/docs/storing-retrieving-metadata)
7070
and make system test HTTP requests. This is required in production for log correlation without
7171
manually setting the $GOOGLE_CLOUD_PROJECT environment variable.
72-

run/logging-manual/test/system.test.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,8 @@ describe('Logging', () => {
6565
if (!ID_TOKEN) {
6666
throw Error('"ID_TOKEN" environment variable is required.');
6767
}
68-
6968
await request('/', {
70-
baseUrl: BASE_URL.trim(),
69+
prefixUrl: BASE_URL.trim(),
7170
headers: {
7271
Authorization: `Bearer ${ID_TOKEN.trim()}`,
7372
},

0 commit comments

Comments
 (0)