Skip to content

Commit 1387f31

Browse files
JustinBeckwithgrayside
authored andcommitted
chore: do not require projectId env for sample tests (#235)
1 parent 79d2571 commit 1387f31

File tree

1 file changed

+22
-15
lines changed

1 file changed

+22
-15
lines changed

cloud-tasks/test/test.samples.js

+22-15
Original file line numberDiff line numberDiff line change
@@ -15,53 +15,60 @@
1515
'use strict';
1616

1717
const {assert} = require('chai');
18-
const cp = require('child_process');
18+
const {execSync} = require('child_process');
1919
const uuid = require('uuid');
20+
const {CloudTasksClient} = require('@google-cloud/tasks');
2021

21-
const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
22-
23-
const PROJECT_ID = process.env.GCLOUD_PROJECT;
22+
const exec = cmd => execSync(cmd, {encoding: 'utf-8'});
2423
const queueName = `gcloud-${uuid.v4().split('-')[0]}`;
25-
const URL = `https://${PROJECT_ID}.appspot.com/log_payload`;
2624
const SERVICE_ACCOUNT =
2725
2826

2927
describe('Cloud Task Sample Tests', () => {
28+
let url;
29+
let projectId;
30+
31+
before(async () => {
32+
const client = new CloudTasksClient();
33+
projectId = await client.getProjectId();
34+
url = `https://${projectId}.appspot.com/log_payload`;
35+
});
36+
3037
it('should create a queue', () => {
31-
const stdout = execSync(`node createQueue ${PROJECT_ID} ${queueName}`);
38+
const stdout = exec(`node createQueue ${projectId} ${queueName}`);
3239
assert.match(stdout, /Created queue/);
3340
});
3441

3542
it('should create a task', () => {
36-
const stdout = execSync(
37-
`node createTask ${PROJECT_ID} us-central1 ${queueName}`
43+
const stdout = exec(
44+
`node createTask ${projectId} us-central1 ${queueName}`
3845
);
3946
assert.match(stdout, /Created task/);
4047
});
4148

4249
it('quickstart sample should create a task', () => {
43-
const stdout = execSync(
44-
`node quickstart ${PROJECT_ID} us-central1 ${queueName}`
50+
const stdout = exec(
51+
`node quickstart ${projectId} us-central1 ${queueName}`
4552
);
4653
assert.match(stdout, /Created task/);
4754
});
4855

4956
it('should create a HTTP task', () => {
50-
const stdout = execSync(
51-
`node createHttpTask ${PROJECT_ID} us-central1 my-appengine-queue ${URL}`
57+
const stdout = exec(
58+
`node createHttpTask ${projectId} us-central1 my-appengine-queue ${url}`
5259
);
5360
assert.match(stdout, /Created task/);
5461
});
5562

5663
it('should create a HTTP task with token', () => {
57-
const stdout = execSync(
58-
`node createHttpTaskWithToken ${PROJECT_ID} us-central1 my-appengine-queue ${URL} ${SERVICE_ACCOUNT}`
64+
const stdout = exec(
65+
`node createHttpTaskWithToken ${projectId} us-central1 my-appengine-queue ${url} ${SERVICE_ACCOUNT}`
5966
);
6067
assert.match(stdout, /Created task/);
6168
});
6269

6370
it('should delete a queue', () => {
64-
const stdout = execSync(`node deleteQueue ${PROJECT_ID} ${queueName}`);
71+
const stdout = exec(`node deleteQueue ${projectId} ${queueName}`);
6572
assert.match(stdout, /Deleted queue/);
6673
});
6774
});

0 commit comments

Comments
 (0)