Skip to content

Commit 2e9428d

Browse files
kelskKelsey Krippaehneaverikitsch
authored
fix Markdown Preview flaky tests (#1879)
* Add service-to-service Node.js sample * Add service-to-service Node.js sample * Update run/authentication/auth.js Co-Authored-By: Averi Kitsch <[email protected]> * Update sample to address suggested changes * Initial code added * Updated package.json; resolved issues in auth.js from review * Removed auth from branch * Markdown renderer & editor added * Markdown renderer & editor working * Added xss sanitizer * General cleanup * Delete .gitignore * Delete .gitignore * Removed errant console.log * Update markdown converter, general code cleanup * updated README * tests: added unit tests for editor & renderer * added timeout * tests: added editor & editor/render tests * tests: added & modified test in package.json * README: added env var * Revert "README: added env var" This reverts commit f43a2af. * README: added env var * updated author email * Update run/markdown-preview/README.md Co-Authored-By: Averi Kitsch <[email protected]> * add license to Dockerfile * fixed json parsing error * remove dependencies from root package.json * remove xss (not needed) * update node version in Dockerfile * refactored code to reflect code review * updated tests to respond to new code * update packages.json * run/markdown-preview: add sample * update: syntax & grammar fixes * change: throw error if markdown data absent from req * change req.body validation * fix syntax error * change: fixed file name * syntax: remove newline * update: engine version * syntax: general fixes * code: replace json with plain text * test: modified tests for accuracy * syntax: minor fixes * test: modified for new code * added comment about xss * code: unwrapped body.data * test: updated tests per code review * code: added timeout to got request * test: updated with sinon & error message reading * test: updated with sinon to read console log * reformatted markdown declaration * test: refactor to make valid tests * Updated sample to use google-auth-library * updated req.body conditional & markdown-it comment * Removed init(); added Renderer url to /render * Updated renderRequest client * Updated get to be async * Updated tests to reflect new code * Removed erroneous comment & outdated env var * Removed unused js package * Added check for service url * Updated service url in test/render * Updated tests with urls & removed incorrect assertion * updated POST request test * updated POST request test * removed 'then' from renderer test * test modifications * Reconfigured serviceUrl * Removed sinon * Updated region tags * Updated valid request test * Update: node 10 => node 12 * Added end to end tests * Update run/markdown-preview/editor/test/system.test.js Co-authored-by: Averi Kitsch <[email protected]> * Added test to system.test.js * Fixed npm test * Fixed renderer test * Updated shell permissions * Updated cleanup func * Update var exports * Added service-name.sh * Removed service-name.sh * Move service.sh functions into runner.sh * Added check for BASE_URL * Fixed system.test env * Add check for BASE_URL var * Added id token * Fixed test; removed allow-auth flag * Added retry to http requests * Updated timeout on Renderer test * Removed all timeouts from tests * Removed retry from render.js Co-authored-by: Kelsey Krippaehne <[email protected]> Co-authored-by: Averi Kitsch <[email protected]>
1 parent 7317547 commit 2e9428d

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

run/markdown-preview/editor/test/system.test.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ describe('End-to-End Tests', () => {
3434
prefixUrl: BASE_URL.trim(),
3535
headers: {
3636
Authorization: `Bearer ${ID_TOKEN.trim()}`
37-
}
37+
},
38+
retry: 1
3839
};
3940
const response = await got('/', options);
4041
assert.strictEqual(response.statusCode, 200);
@@ -49,7 +50,9 @@ describe('End-to-End Tests', () => {
4950
method: 'POST',
5051
json: {
5152
"data": "**markdown**"
52-
}
53+
54+
},
55+
retry: 1
5356
};
5457
const response = await got('/render', options);
5558
assert.strictEqual(response.statusCode, 200);

0 commit comments

Comments
 (0)