Skip to content

Commit 6d2e1aa

Browse files
authored
Fix kokoro config (#662)
Allowed values are standard and flex. Use them for the version. Always deploy app.yaml, so don't specify it.
1 parent a74d7e6 commit 6d2e1aa

8 files changed

+37
-8
lines changed

.kokoro/appengine/test-deployment/common.cfg

-7
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,4 @@ env_vars: {
1919
env_vars: {
2020
key: "TRAMPOLINE_BUILD_FILE"
2121
value: "github/nodejs-docs-samples/.kokoro/build-with-appengine.sh"
22-
}
23-
24-
25-
# Used in `gcloud app deploy ${APPENGINE_ENVIRONMENT}.yaml
26-
env_vars: {
27-
key: "APPENGINE_ENVIRONMENT"
28-
value: "app"
2922
}

.kokoro/appengine/test-deployment/hello-world-flex.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/hello-world/flexible"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "flexible"
713
}

.kokoro/appengine/test-deployment/hello-world-standard.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/hello-world/standard"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "standard"
713
}

.kokoro/appengine/test-deployment/metadata-flex.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/metadata/flexible"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "flexible"
713
}

.kokoro/appengine/test-deployment/metadata-standard.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/metadata/standard"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "standard"
713
}

.kokoro/appengine/test-deployment/storage-flex.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/storage/flexible"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "flexible"
713
}

.kokoro/appengine/test-deployment/storage-standard.cfg

+6
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,10 @@
44
env_vars: {
55
key: "PROJECT"
66
value: "appengine/storage/standard"
7+
}
8+
9+
# flexible or standard
10+
env_vars: {
11+
key: "APPENGINE_ENVIRONMENT"
12+
value: "standard"
713
}

.kokoro/build-with-appengine.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ gcloud config set project $GCLOUD_PROJECT
4848

4949

5050
# Deploy the app
51-
gcloud app deploy ${APPENGINE_ENVIRONMENT}.yaml --version $GAE_VERSION --no-promote --quiet
51+
gcloud app deploy --version $GAE_VERSION --no-promote --quiet
5252
if [ -e "worker.yaml" ]; then
5353
gcloud app deploy worker.yaml --version ${GAE_VERSION} --no-promote --quiet
5454
fi

0 commit comments

Comments
 (0)