Switch from Mocha to Ava for faster tests (#289)

* Switch from Mocha to Ava

* Concurrency: 5

Author: jmdobry

monitoring/snippets/package.json

@@ -5,8 +5,7 @@
   "license": "Apache Version 2.0",
   "author": "Google Inc.",
   "scripts": {
-    "test": "cd ..; npm run t -- monitoring/test/*.test.js",
-    "system-test": "cd ..; npm run st -- monitoring/system-test/*.test.js"
+    "test": "cd ..; npm run st -- monitoring/system-test/*.test.js"
   },
   "dependencies": {
     "async":"2.1.2",

monitoring/snippets/system-test/create_custom_metric.test.js

@@ -13,37 +13,40 @@
 
 'use strict';
 
-var customMetricsExample = require('../create_custom_metric');
+require(`../../system-test/_setup`);
+
+const customMetricsExample = require('../create_custom_metric');
 
 /** Refactored out to keep lines shorter */
 function getPointValue (timeSeries) {
   return timeSeries.timeSeries[0].points[0].value.int64Value;
 }
 
-describe('monitoring:create_custom_metric', function () {
-  it('should create and read back a custom metric', function (done) {
-    customMetricsExample.main(
-      process.env.GCLOUD_PROJECT,
-      Math.random().toString(36).substring(7),
-      function (err, results) {
-        assert.ifError(err);
-        assert(results.length === 4);
-        // Result of creating metric
-        assert(typeof results[0].name === 'string');
-        // Result of writing time series
-        assert.deepEqual(results[1], {});
-        // Result of reading time series
-        assert(typeof getPointValue(results[2]) === 'string');
-        assert(!isNaN(parseInt(getPointValue(results[2]), 10)));
-        // Result of deleting metric
-        assert.deepEqual(results[3], {});
-        assert(console.log.calledWith('Created custom metric'));
-        assert(console.log.calledWith('Wrote time series'));
-        assert(console.log.calledWith('Reading metric type'));
-        assert(console.log.calledWith('Time series'));
-        assert(console.log.calledWith('Deleted metric'));
-        done();
-      }
-    );
-  });
+test.before(stubConsole);
+test.after(restoreConsole);
+
+test.cb('should create and read back a custom metric', (t) => {
+  customMetricsExample.main(
+    process.env.GCLOUD_PROJECT,
+    Math.random().toString(36).substring(7),
+    (err, results) => {
+      t.ifError(err);
+      t.is(results.length, 4);
+      // Result of creating metric
+      t.is(typeof results[0].name, 'string');
+      // Result of writing time series
+      t.deepEqual(results[1], {});
+      // Result of reading time series
+      t.is(typeof getPointValue(results[2]), 'string');
+      t.false(isNaN(parseInt(getPointValue(results[2]), 10)));
+      // Result of deleting metric
+      t.deepEqual(results[3], {});
+      t.true(console.log.calledWith('Created custom metric'));
+      t.true(console.log.calledWith('Wrote time series'));
+      t.true(console.log.calledWith('Reading metric type'));
+      t.true(console.log.calledWith('Time series'));
+      t.true(console.log.calledWith('Deleted metric'));
+      t.end();
+    }
+  );
 });

monitoring/snippets/system-test/list_resources.test.js

@@ -13,26 +13,26 @@
 
 'use strict';
 
-var listResourcesExample = require('../list_resources');
+require(`../../system-test/_setup`);
 
-describe('monitoring:list_resources', function () {
-  it('should list a bunch of stuff', function (done) {
-    listResourcesExample.main(
-      process.env.GCLOUD_PROJECT,
-      function (err, results) {
-        assert.ifError(err);
-        assert(results.length === 3);
-        // Monitored resources
-        assert(Array.isArray(results[0].resourceDescriptors));
-        // Metric descriptors
-        assert(Array.isArray(results[1].metricDescriptors));
-        // Time series
-        assert(Array.isArray(results[2].timeSeries));
-        assert(console.log.calledWith('Monitored resources'));
-        assert(console.log.calledWith('Metric descriptors'));
-        assert(console.log.calledWith('Time series'));
-        done();
-      }
-    );
+const listResourcesExample = require(`../list_resources`);
+
+test.before(stubConsole);
+test.after(restoreConsole);
+
+test.cb(`should list a bunch of stuff`, (t) => {
+  listResourcesExample.main(process.env.GCLOUD_PROJECT, (err, results) => {
+    t.ifError(err);
+    t.is(results.length, 3);
+    // Monitored resources
+    t.true(Array.isArray(results[0].resourceDescriptors));
+    // Metric descriptors
+    t.true(Array.isArray(results[1].metricDescriptors));
+    // Time series
+    t.true(Array.isArray(results[2].timeSeries));
+    t.true(console.log.calledWith('Monitored resources'));
+    t.true(console.log.calledWith('Metric descriptors'));
+    t.true(console.log.calledWith('Time series'));
+    t.end();
   });
 });