Skip to content

Update datastore dependency fails #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fhinkel opened this issue Jun 4, 2020 · 4 comments
Closed

Update datastore dependency fails #1844

fhinkel opened this issue Jun 4, 2020 · 4 comments
Assignees
@fhinkel
Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Jun 4, 2020

See #1839
@fhinkel fhinkel added api: datastore Issues related to the Datastore API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 4, 2020
@BenWhitehead
Copy link

Looks like we need to bump the env to be node 10+ instead of 8

failure log 
Status: Downloaded newer image for gcr.io/cloud-devrel-kokoro-resources/node:8-user
Executing: docker run --rm --interactive --network=host --privileged --volume=/var/run/docker.sock:/var/run/docker.sock --workdir=/tmpfs/src --entrypoint=github/nodejs-docs-samples/.kokoro/build.sh --env-file=/tmpfs/tmp/tmp0dw91rvm/envfile --volume=/tmpfs:/tmpfs gcr.io/cloud-devrel-kokoro-resources/node:8-user
/tmpfs/src/github/nodejs-docs-samples /tmpfs/src
/tmpfs/src

> [email protected] postinstall /tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN notsup Unsupported engine for @google-cloud/[email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: @google-cloud/[email protected]
npm WARN notsup Unsupported engine for @google-cloud/[email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: @google-cloud/[email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=10"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: [email protected]
npm WARN notsup Unsupported engine for @google-cloud/[email protected]: wanted: {"node":">=10.0.0"} (current: {"node":"8.17.0","npm":"6.13.4"})
npm WARN notsup Not compatible with your version of node/npm: @google-cloud/[email protected]
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@~2.1.1 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 309 packages from 559 contributors and audited 311 packages in 9.245s

18 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

Activated service account credentials for: [[email protected]]
Updated property [core/project].

> nodejs-docs-samples-functions-datastore@ test /tmpfs/src/github/nodejs-docs-samples/datastore/functions
> mocha test/*.test.js --timeout=5000


Error: Node.js v10.0.0 is a minimum requirement. To learn about legacy version support visit: https://github.com/googleapis/google-cloud-node#supported-nodejs-versions
    at new GrpcClient (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/google-gax/build/src/grpc.js:63:19)
    at Object.<anonymous> (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/@google-cloud/datastore/build/src/index.js:39:18)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/test/index.test.js:24:21)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at /tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/mocha.js:349:36
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/mocha.js:346:14)
    at /tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/mocha.js:382:12
    at new Promise (<anonymous>)
    at Mocha.loadFilesAsync (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/mocha.js:381:12)
    at singleRun (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/cli/run-helpers.js:149:15)
    at exports.runMocha (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/cli/run-helpers.js:186:11)
    at Object.exports.handler (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/mocha/lib/cli/run.js:319:11)
    at innerArgv.then.argv (/tmpfs/src/github/nodejs-docs-samples/datastore/functions/node_modules/yargs/lib/command.js:241:49)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
    at Function.Module.runMain (module.js:696:11)
    at startup (bootstrap_node.js:204:16)
    at bootstrap_node.js:625:3
npm ERR! Test failed.  See above for more details.


[ID: 6257229] Build finished after 56 secs, exit value: 1

@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 5, 2020

Blocked by #1855 for GAE and we want to hold off with an update in GCF.

@fhinkel fhinkel assigned fhinkel and unassigned BenWhitehead Jun 5, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 10, 2020
@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 15, 2020
@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 23, 2020

#1886

@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 23, 2020

fixed with #1886

@fhinkel fhinkel closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhinkel fhinkel

Labels
api: datastore Issues related to the Datastore API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fhinkel @BenWhitehead @yoshi-automation