From 3f36b9da7ac4001efa2fb0536ed214e579ba3e55 Mon Sep 17 00:00:00 2001 From: Remigiusz Samborski Date: Thu, 20 Apr 2023 12:14:42 +0200 Subject: [PATCH] chore(docs): Update PR template with missing steps [Per discussion](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/pull/3143#issuecomment-1515336096) we should make sure that users don't miss workflow generation when creating a new folder. Moreover a missing CODEOWNERS step was added here as well. --- .github/PULL_REQUEST_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3fb10fb3cd..857a840187 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,5 +10,7 @@ Note: Before submitting a pull request, please open an issue for discussion if y - [ ] **Lint** pass: `npm run lint` (see [Style](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#style)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) +- [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CODEOWNERS) with the codeowners for this sample +- [ ] This sample adds a new sample directory, and I created [GitHub Actions workflow](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/CONTRIBUTING.md#adding-new-samples) for this sample - [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample -- [ ] Please **merge** this PR for me once it is approved \ No newline at end of file +- [ ] Please **merge** this PR for me once it is approved