From 95992b892a8d281bad161eb7a5cfa1f6724860d4 Mon Sep 17 00:00:00 2001 From: Olu Omoniyi Date: Tue, 27 Mar 2018 01:50:35 +0100 Subject: [PATCH 1/4] fix the params sent across to the ga endpoint. spreading the results allows the endpoint to pick up the individual params. Previous method does not work. see https://developers.google.com/analytics/devguides/collection/protocol/v1/reference for more --- appengine/analytics/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/analytics/app.js b/appengine/analytics/app.js index 3ad08f9b9f..8d8b2ed2cc 100644 --- a/appengine/analytics/app.js +++ b/appengine/analytics/app.js @@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) { }; return got.post('http://www.google-analytics.com/collect', { - form: data + ...data }); } From 642b71641377dcad510215a4d6b23da1ffa765bd Mon Sep 17 00:00:00 2001 From: Olu Omoniyi Date: Tue, 27 Mar 2018 01:56:32 +0100 Subject: [PATCH 2/4] add semicolon add semicolon --- appengine/analytics/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/analytics/app.js b/appengine/analytics/app.js index 8d8b2ed2cc..3d64c922cd 100644 --- a/appengine/analytics/app.js +++ b/appengine/analytics/app.js @@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) { }; return got.post('http://www.google-analytics.com/collect', { - ...data + ...data; }); } From cb0e1e239e139b95aedfcb1d4f2d031008965e5e Mon Sep 17 00:00:00 2001 From: Olu Omoniyi Date: Tue, 27 Mar 2018 02:03:23 +0100 Subject: [PATCH 3/4] removed silly semi colon! removed silly semi colon! --- appengine/analytics/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appengine/analytics/app.js b/appengine/analytics/app.js index 3d64c922cd..8d8b2ed2cc 100644 --- a/appengine/analytics/app.js +++ b/appengine/analytics/app.js @@ -48,7 +48,7 @@ function trackEvent (category, action, label, value, cb) { }; return got.post('http://www.google-analytics.com/collect', { - ...data; + ...data }); } From e97da6aafe6dcee911111bc95d13a204c5fa6935 Mon Sep 17 00:00:00 2001 From: Olu Omoniyi Date: Thu, 29 Mar 2018 00:46:41 +0100 Subject: [PATCH 4/4] Updated to Object.assign for legacy Node --- appengine/analytics/app.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/appengine/analytics/app.js b/appengine/analytics/app.js index 8d8b2ed2cc..ecf879fab8 100644 --- a/appengine/analytics/app.js +++ b/appengine/analytics/app.js @@ -47,9 +47,7 @@ function trackEvent (category, action, label, value, cb) { ev: value }; - return got.post('http://www.google-analytics.com/collect', { - ...data - }); + return got.post('http://www.google-analytics.com/collect', Object.assign({}, data)); } app.get('/', (req, res, next) => {