Skip to content

Commit 1c7d458

Browse files
authored
update to OT master (#22)
* update to OT master * lint * update commit hash * remove extraneous files
1 parent 0ceadd4 commit 1c7d458

File tree

6 files changed

+14
-13
lines changed

6 files changed

+14
-13
lines changed

opentelemetry-exporter-cloud-trace/src/opentelemetry/exporter/cloud_trace/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@
4444
from typing import Any, Dict, List, Optional, Sequence, Tuple
4545

4646
import google.auth
47+
import opentelemetry.trace as trace_api
4748
import pkg_resources
4849
from google.cloud.trace_v2 import TraceServiceClient
4950
from google.cloud.trace_v2.proto.trace_pb2 import AttributeValue
5051
from google.cloud.trace_v2.proto.trace_pb2 import Span as ProtoSpan
5152
from google.cloud.trace_v2.proto.trace_pb2 import TruncatableString
5253
from google.rpc.status_pb2 import Status
53-
from opentelemetry import trace as trace_api
5454
from opentelemetry.exporter.cloud_trace.version import (
5555
__version__ as cloud_trace_version,
5656
)

opentelemetry-exporter-cloud-trace/src/opentelemetry/exporter/cloud_trace/cloud_trace_propagator.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import re
1717
import typing
1818

19-
from opentelemetry import trace
19+
import opentelemetry.trace as trace
2020
from opentelemetry.context.context import Context
2121
from opentelemetry.trace.propagation import httptextformat
2222
from opentelemetry.trace.span import (
@@ -27,8 +27,6 @@
2727

2828
_TRACE_CONTEXT_HEADER_NAME = "X-Cloud-Trace-Context"
2929
_TRACE_CONTEXT_HEADER_FORMAT = r"(?P<trace_id>[0-9a-f]{32})\/(?P<span_id>[\d]{1,20});o=(?P<trace_flags>\d+)"
30-
31-
3230
_TRACE_CONTEXT_HEADER_RE = re.compile(_TRACE_CONTEXT_HEADER_FORMAT)
3331

3432

@@ -79,8 +77,6 @@ def inject(
7977
context: typing.Optional[Context] = None,
8078
) -> None:
8179
span = trace.get_current_span(context)
82-
if span is None:
83-
return
8480
span_context = span.get_context()
8581
if span_context == trace.INVALID_SPAN_CONTEXT:
8682
return

opentelemetry-exporter-cloud-trace/tests/test_cloud_trace_exporter.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,10 @@ def test_extract_links(self):
304304
),
305305
)
306306

307-
def test_extract_resources(self):
307+
def test_extract_empty_resources(self):
308308
self.assertEqual(_extract_resources(Resource.create_empty()), {})
309+
310+
def test_extract_well_formed_resources(self):
309311
resource = Resource(
310312
labels={
311313
"cloud.account.id": 123,
@@ -324,19 +326,19 @@ def test_extract_resources(self):
324326
}
325327
self.assertEqual(_extract_resources(resource), expected_extract)
326328

329+
def test_extract_malformed_resources(self):
330+
# This resource doesn't have all the fields required for a gce_instance
331+
# Specifically its missing "host.id", "cloud.zone", "cloud.account.id"
327332
resource = Resource(
328333
labels={
329-
"cloud.account.id": "123",
330-
"host.id": "host",
331-
"extra_info": "extra",
332-
"not_gcp_resource": "value",
333334
"gcp.resource_type": "gce_instance",
334335
"cloud.provider": "gcp",
335336
}
336337
)
337338
# Should throw when passed a malformed GCP resource dict
338339
self.assertRaises(KeyError, _extract_resources, resource)
339340

341+
def test_extract_unsupported_gcp_resources(self):
340342
resource = Resource(
341343
labels={
342344
"cloud.account.id": "123",
@@ -349,6 +351,8 @@ def test_extract_resources(self):
349351
)
350352
self.assertEqual(_extract_resources(resource), {})
351353

354+
def test_extract_unsupported_provider_resources(self):
355+
# Resources with currently unsupported providers will be ignored
352356
resource = Resource(
353357
labels={
354358
"cloud.account.id": "123",

opentelemetry-exporter-cloud-trace/tests/test_cloud_trace_propagator.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import typing
1616
import unittest
1717

18-
from opentelemetry import trace
18+
import opentelemetry.trace as trace
1919
from opentelemetry.context import get_current
2020
from opentelemetry.exporter.cloud_trace.cloud_trace_propagator import (
2121
_TRACE_CONTEXT_HEADER_NAME,

opentelemetry-exporter-cloud-trace/tests/test_gcp_resource_detector.py

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ def test_finding_resources(self, getter):
6767
)
6868
self.assertEqual(getter.call_count, 1)
6969

70+
# Found resources should be cached and not require another network call
7071
found_resources = resource_finder.detect()
7172
self.assertEqual(getter.call_count, 1)
7273
self.assertEqual(

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ envlist =
2222
; against releases and remove this. For now, bump this frequently with every PR
2323
; to develop as closely with that repo as possible while still tracking the
2424
; actual hash.
25-
opentelemetry_python_commit = 8cbd9d4db04f0cd0b5a32c8c8c80299b4a44f9bd
25+
opentelemetry_python_commit = 545068d6eb61beaab031af45b1572d70e6652bc3
2626
opentelemetry_api_dep =
2727
git+https://github.com/open-telemetry/opentelemetry-python.git@{[constants]opentelemetry_python_commit}#egg=opentelemetry-api&subdirectory=opentelemetry-api
2828
opentelemetry_sdk_dep =

0 commit comments

Comments
 (0)