@@ -304,8 +304,10 @@ def test_extract_links(self):
304
304
),
305
305
)
306
306
307
- def test_extract_resources (self ):
307
+ def test_extract_empty_resources (self ):
308
308
self .assertEqual (_extract_resources (Resource .create_empty ()), {})
309
+
310
+ def test_extract_well_formed_resources (self ):
309
311
resource = Resource (
310
312
labels = {
311
313
"cloud.account.id" : 123 ,
@@ -324,19 +326,19 @@ def test_extract_resources(self):
324
326
}
325
327
self .assertEqual (_extract_resources (resource ), expected_extract )
326
328
329
+ def test_extract_malformed_resources (self ):
330
+ # This resource doesn't have all the fields required for a gce_instance
331
+ # Specifically its missing "host.id", "cloud.zone", "cloud.account.id"
327
332
resource = Resource (
328
333
labels = {
329
- "cloud.account.id" : "123" ,
330
- "host.id" : "host" ,
331
- "extra_info" : "extra" ,
332
- "not_gcp_resource" : "value" ,
333
334
"gcp.resource_type" : "gce_instance" ,
334
335
"cloud.provider" : "gcp" ,
335
336
}
336
337
)
337
338
# Should throw when passed a malformed GCP resource dict
338
339
self .assertRaises (KeyError , _extract_resources , resource )
339
340
341
+ def test_extract_unsupported_gcp_resources (self ):
340
342
resource = Resource (
341
343
labels = {
342
344
"cloud.account.id" : "123" ,
@@ -349,6 +351,8 @@ def test_extract_resources(self):
349
351
)
350
352
self .assertEqual (_extract_resources (resource ), {})
351
353
354
+ def test_extract_unsupported_provider_resources (self ):
355
+ # Resources with currently unsupported providers will be ignored
352
356
resource = Resource (
353
357
labels = {
354
358
"cloud.account.id" : "123" ,
0 commit comments