Skip to content

Commit 38d82a3

Browse files
jmdobrydanoscarmike
authored andcommitted
Translate API no longer requires an API key. [(#659)](#659)
1 parent a055abe commit 38d82a3

File tree

4 files changed

+20
-41
lines changed

4 files changed

+20
-41
lines changed

translation/samples/snippets/quickstart.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@ def run_quickstart():
2020
# Imports the Google Cloud client library
2121
from google.cloud import translate
2222

23-
# Your Translate API key
24-
api_key = 'YOUR_API_KEY'
25-
2623
# Instantiates a client
27-
translate_client = translate.Client(api_key=api_key)
24+
translate_client = translate.Client()
2825

2926
# The text to translate
3027
text = u'Hello, world!'

translation/samples/snippets/quickstart_test.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -13,28 +13,11 @@
1313
# See the License for the specific language governing permissions and
1414
# limitations under the License.
1515

16-
from google.cloud import translate
17-
import mock
18-
import pytest
1916

2017
import quickstart
2118

2219

23-
@pytest.fixture
24-
def mock_client(cloud_config):
25-
original_client_ctor = translate.Client
26-
27-
def new_client_ctor(api_key):
28-
# Strip api_key argument and replace with our api key.
29-
return original_client_ctor(cloud_config.api_key)
30-
31-
with mock.patch(
32-
'google.cloud.translate.Client',
33-
side_effect=new_client_ctor):
34-
yield
35-
36-
37-
def test_quickstart(mock_client, capsys):
20+
def test_quickstart(capsys):
3821
quickstart.run_quickstart()
3922
out, _ = capsys.readouterr()
4023
assert u'Привет мир!' in out

translation/samples/snippets/snippets.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@
2626
from google.cloud import translate
2727

2828

29-
def detect_language(api_key, text):
29+
def detect_language(text):
3030
"""Detects the text's language."""
31-
translate_client = translate.Client(api_key=api_key)
31+
translate_client = translate.Client()
3232

3333
# Text can also be a sequence of strings, in which case this method
3434
# will return a sequence of results for each text.
@@ -39,39 +39,39 @@ def detect_language(api_key, text):
3939
print('Language: {}'.format(result['language']))
4040

4141

42-
def list_languages(api_key):
42+
def list_languages():
4343
"""Lists all available languages."""
44-
translate_client = translate.Client(api_key=api_key)
44+
translate_client = translate.Client()
4545

4646
results = translate_client.get_languages()
4747

4848
for language in results:
4949
print(u'{name} ({language})'.format(**language))
5050

5151

52-
def list_languages_with_target(api_key, target):
52+
def list_languages_with_target(target):
5353
"""Lists all available languages and localizes them to the target language.
5454
5555
Target must be an ISO 639-1 language code.
5656
See https://g.co/cloud/translate/v2/translate-reference#supported_languages
5757
"""
58-
translate_client = translate.Client(api_key=api_key)
58+
translate_client = translate.Client()
5959

6060
results = translate_client.get_languages(target_language=target)
6161

6262
for language in results:
6363
print(u'{name} ({language})'.format(**language))
6464

6565

66-
def translate_text_with_model(api_key, target, text, model=translate.BASE):
66+
def translate_text_with_model(target, text, model=translate.BASE):
6767
"""Translates text into the target language.
6868
6969
Make sure your project is whitelisted.
7070
7171
Target must be an ISO 639-1 language code.
7272
See https://g.co/cloud/translate/v2/translate-reference#supported_languages
7373
"""
74-
translate_client = translate.Client(api_key=api_key)
74+
translate_client = translate.Client()
7575

7676
# Text can also be a sequence of strings, in which case this method
7777
# will return a sequence of results for each text.
@@ -86,13 +86,13 @@ def translate_text_with_model(api_key, target, text, model=translate.BASE):
8686
result['detectedSourceLanguage']))
8787

8888

89-
def translate_text(api_key, target, text):
89+
def translate_text(target, text):
9090
"""Translates text into the target language.
9191
9292
Target must be an ISO 639-1 language code.
9393
See https://g.co/cloud/translate/v2/translate-reference#supported_languages
9494
"""
95-
translate_client = translate.Client(api_key=api_key)
95+
translate_client = translate.Client()
9696

9797
# Text can also be a sequence of strings, in which case this method
9898
# will return a sequence of results for each text.
@@ -110,7 +110,6 @@ def translate_text(api_key, target, text):
110110
parser = argparse.ArgumentParser(
111111
description=__doc__,
112112
formatter_class=argparse.RawDescriptionHelpFormatter)
113-
parser.add_argument('api_key', help='Your API key.')
114113
subparsers = parser.add_subparsers(dest='command')
115114

116115
detect_langage_parser = subparsers.add_parser(
@@ -132,10 +131,10 @@ def translate_text(api_key, target, text):
132131
args = parser.parse_args()
133132

134133
if args.command == 'detect-language':
135-
detect_language(args.api_key, args.text)
134+
detect_language(args.text)
136135
elif args.command == 'list-languages':
137-
list_languages(args.api_key)
136+
list_languages()
138137
elif args.command == 'list-languages-with-target':
139-
list_languages_with_target(args.api_key, args.target)
138+
list_languages_with_target(args.target)
140139
elif args.command == 'translate-text':
141-
translate_text(args.api_key, args.target, args.text)
140+
translate_text(args.target, args.text)

translation/samples/snippets/snippets_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,24 +19,24 @@
1919

2020

2121
def test_detect_language(cloud_config, capsys):
22-
snippets.detect_language(cloud_config.api_key, 'Hæ sæta')
22+
snippets.detect_language('Hæ sæta')
2323
out, _ = capsys.readouterr()
2424
assert 'is' in out
2525

2626

2727
def test_list_languages(cloud_config, capsys):
28-
snippets.list_languages(cloud_config.api_key)
28+
snippets.list_languages()
2929
out, _ = capsys.readouterr()
3030
assert 'Icelandic (is)' in out
3131

3232

3333
def test_list_languages_with_target(cloud_config, capsys):
34-
snippets.list_languages_with_target(cloud_config.api_key, 'is')
34+
snippets.list_languages_with_target('is')
3535
out, _ = capsys.readouterr()
3636
assert u'íslenska (is)' in out
3737

3838

3939
def test_translate_text(cloud_config, capsys):
40-
snippets.translate_text(cloud_config.api_key, 'is', 'Hello world')
40+
snippets.translate_text('is', 'Hello world')
4141
out, _ = capsys.readouterr()
4242
assert u'Halló heimur' in out

0 commit comments

Comments
 (0)