Skip to content

Commit 4b91143

Browse files
author
Takashi Matsuo
authored
[iam] testing: use uniqueId instead of email (#4094)
* [iam] bigger entropy for unique id * [iam] testing: use uniqueId instead of email fixes #4087 * lint fix
1 parent 2bc61a2 commit 4b91143

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

iam/api-client/service_accounts_test.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,23 @@
2222

2323
def test_service_accounts(capsys):
2424
project_id = os.environ['GOOGLE_CLOUD_PROJECT']
25-
name = 'python-test-{}'.format(str(uuid.uuid4()).split('-')[0])
26-
email = name + '@' + project_id + '.iam.gserviceaccount.com'
25+
name = f'test-{uuid.uuid4().hex[:25]}'
2726

2827
try:
29-
service_accounts.create_service_account(
28+
acct = service_accounts.create_service_account(
3029
project_id, name, 'Py Test Account')
30+
assert('uniqueId' in acct)
31+
32+
unique_id = acct['uniqueId']
3133
service_accounts.list_service_accounts(project_id)
3234
service_accounts.rename_service_account(
33-
email, 'Updated Py Test Account')
34-
service_accounts.disable_service_account(email)
35-
service_accounts.enable_service_account(email)
36-
service_accounts.delete_service_account(email)
35+
unique_id, 'Updated Py Test Account')
36+
service_accounts.disable_service_account(unique_id)
37+
service_accounts.enable_service_account(unique_id)
38+
service_accounts.delete_service_account(unique_id)
3739
finally:
3840
try:
39-
service_accounts.delete_service_account(email)
41+
service_accounts.delete_service_account(unique_id)
4042
except HttpError as e:
4143
# When the service account doesn't exist, the service returns 403.
4244
if '403' in str(e):

0 commit comments

Comments
 (0)