Skip to content

Commit 7c73e04

Browse files
kchertenkoparthea
andauthored
fix: remove add_time param from LRO requests. (#336)
Co-authored-by: Anthonios Partheniou <[email protected]>
1 parent 2237de6 commit 7c73e04

File tree

3 files changed

+10
-27
lines changed

3 files changed

+10
-27
lines changed

generated_samples/interactive-tutorials/product/add_fulfillment_places.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# [START retail_add_fulfillment_places]
1616
# Adding place IDs using Retail API.
1717
#
18-
import datetime
1918
import random
2019
import string
2120
import time
@@ -37,13 +36,12 @@
3736

3837
# add fulfillment request
3938
def get_add_fulfillment_request(
40-
product_name: str, timestamp, place_id
39+
product_name: str, place_id
4140
) -> AddFulfillmentPlacesRequest:
4241
add_fulfillment_request = AddFulfillmentPlacesRequest()
4342
add_fulfillment_request.product = product_name
4443
add_fulfillment_request.type_ = "pickup-in-store"
4544
add_fulfillment_request.place_ids = [place_id]
46-
add_fulfillment_request.add_time = timestamp
4745
add_fulfillment_request.allow_missing = True
4846

4947
print("---add fulfillment request---")
@@ -53,10 +51,8 @@ def get_add_fulfillment_request(
5351

5452

5553
# add fulfillment places to product
56-
def add_fulfillment_places(product_name: str, timestamp, place_id):
57-
add_fulfillment_request = get_add_fulfillment_request(
58-
product_name, timestamp, place_id
59-
)
54+
def add_fulfillment_places(product_name: str, place_id):
55+
add_fulfillment_request = get_add_fulfillment_request(product_name, place_id)
6056
ProductServiceClient().add_fulfillment_places(add_fulfillment_request)
6157

6258
# This is a long running operation and its result is not immediately present with get operations,
@@ -70,9 +66,7 @@ def add_fulfillment_places(product_name: str, timestamp, place_id):
7066

7167
create_product(product_id)
7268

73-
# The request timestamp
74-
current_date = datetime.datetime.now() + datetime.timedelta(seconds=30)
75-
print(f"------add fulfilment places with current date: {current_date}-----")
76-
add_fulfillment_places(product_name, current_date, "store2")
69+
print("------add fulfilment places-----")
70+
add_fulfillment_places(product_name, "store2")
7771
get_product(product_name)
7872
delete_product(product_name)

generated_samples/interactive-tutorials/product/remove_fulfillment_places.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# [START retail_remove_fulfillment_places]
1616
# Remove place IDs using Retail API.
1717
#
18-
import datetime
1918
import random
2019
import string
2120
import time
@@ -29,13 +28,12 @@
2928

3029
# remove fulfillment request
3130
def get_remove_fulfillment_request(
32-
product_name: str, timestamp, store_id
31+
product_name: str, store_id
3332
) -> RemoveFulfillmentPlacesRequest:
3433
remove_fulfillment_request = RemoveFulfillmentPlacesRequest()
3534
remove_fulfillment_request.product = product_name
3635
remove_fulfillment_request.type_ = "pickup-in-store"
3736
remove_fulfillment_request.place_ids = [store_id]
38-
remove_fulfillment_request.remove_time = timestamp
3937
remove_fulfillment_request.allow_missing = True
4038

4139
print("---remove fulfillment request---")
@@ -45,10 +43,8 @@ def get_remove_fulfillment_request(
4543

4644

4745
# remove fulfillment places to product
48-
def remove_fulfillment_places(product_name: str, timestamp, store_id):
49-
remove_fulfillment_request = get_remove_fulfillment_request(
50-
product_name, timestamp, store_id
51-
)
46+
def remove_fulfillment_places(product_name: str, store_id):
47+
remove_fulfillment_request = get_remove_fulfillment_request(product_name, store_id)
5248
ProductServiceClient().remove_fulfillment_places(remove_fulfillment_request)
5349

5450
# This is a long running operation and its result is not immediately present with get operations,
@@ -62,10 +58,7 @@ def remove_fulfillment_places(product_name: str, timestamp, store_id):
6258

6359
product = create_product(product_id)
6460

65-
# The request timestamp
66-
current_date = datetime.datetime.now()
67-
68-
print(f"------remove fulfilment places with current date: {current_date}-----")
69-
remove_fulfillment_places(product.name, current_date, "store0")
61+
print("------remove fulfilment places-----")
62+
remove_fulfillment_places(product.name, "store0")
7063
get_product(product.name)
7164
delete_product(product.name)

generated_samples/interactive-tutorials/product/set_inventory.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
# [START retail_set_inventory]
1616
# Updating inventory information using Retail API.
1717
#
18-
import datetime
1918
import random
2019
import string
2120
import time
@@ -65,15 +64,12 @@ def get_product_with_inventory_info(product_name: str) -> Product:
6564

6665
# set inventory request
6766
def get_set_inventory_request(product_name: str) -> SetInventoryRequest:
68-
# The request timestamp
69-
request_time = datetime.datetime.now() + datetime.timedelta(seconds=30)
7067
set_mask = FieldMask(
7168
paths=["price_info", "availability", "fulfillment_info", "available_quantity"]
7269
)
7370

7471
set_inventory_request = SetInventoryRequest()
7572
set_inventory_request.inventory = get_product_with_inventory_info(product_name)
76-
set_inventory_request.set_time = request_time
7773
set_inventory_request.allow_missing = True
7874
set_inventory_request.set_mask = set_mask
7975

0 commit comments

Comments
 (0)