Skip to content

Commit 8144a69

Browse files
author
Jon Wayne Parrott
committed
Address post-review comments for BigQuery samples
Change-Id: I74627bc2744d3b0946d34c1d2a04c424ed708e87
1 parent 5b7ff95 commit 8144a69

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

bigquery/cloud-client/snippets.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,9 @@ def list_rows(dataset_name, table_name, project=None):
104104
rows = []
105105
page_token = None
106106

107+
# Load at most 25 results. You can change this to `while True` and change
108+
# the max_results argument to load more rows from BigQuery, but note
109+
# that this can take some time. It's preferred to use a query.
107110
while len(rows) < 25:
108111
results, total_rows, page_token = table.fetch_data(
109112
max_results=25, page_token=page_token)

bigquery/cloud-client/snippets_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def test_list_datasets(capsys):
4040

4141

4242
def test_list_tables(capsys):
43-
# Requires teh dataset and table to have been created in the test project.
43+
# Requires the dataset and table to have been created in the test project.
4444
snippets.list_tables(DATASET_ID)
4545

4646
out, _ = capsys.readouterr()

0 commit comments

Comments
 (0)